Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1023] [MERGED] [BUG]: Many controls lack screen reader labels #3558

New Issue
Closed
opened 2026-02-22 18:34:01 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:01 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1023
Author: @cartertemm
Created: 4/2/2024
Status: ✅ Merged
Merged: 4/3/2024
Merged by: @timothycarambat

Base: master ← Head: 1022-bug-screen-reader-labels

📝 Commits (6)

  • 0e7c030 Add accessible labels for back and continue buttons in onboarding flow
  • 3270e08 Add accessible label to stop generating button
  • 70314ae Accessible labels for chat history actions (thumb up/down and copy)
  • 1251283 Accessible labels for social links in footer
  • 6a80b96 Accessible labels for home and settings links
  • add7dfc * Accessible labels for home, show sidebar (mobile), and workspace and thread lists.

📊 Changes

9 files changed (+24 additions, -4 deletions)

View changed files

📝 frontend/src/components/Footer/index.jsx (+3 -0)
📝 frontend/src/components/SettingsButton/index.jsx (+2 -0)
📝 frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/ThreadItem/index.jsx (+6 -1)
📝 frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx (+1 -1)
📝 frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx (+5 -2)
📝 frontend/src/components/Sidebar/index.jsx (+2 -0)
📝 frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/HistoricalMessage/Actions/index.jsx (+2 -0)
📝 frontend/src/components/WorkspaceChat/ChatContainer/PromptInput/StopGenerationButton/index.jsx (+1 -0)
📝 frontend/src/pages/OnboardingFlow/Steps/index.jsx (+2 -0)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1022

What is in this change?

Invisible changes to the UI that offer considerable improvements to the accessibility of the application for screen reader users. Most of the buttons are now spoken properly, and related controls have been grouped to make it possible to quickly reach the workspace and threads lists.

Additional Information

Full list of changes:

  • Label the back button on the onboarding screen
  • Label the continue button on the onboarding screen
  • Label the social links, which are currently only represented by images
  • Label some of the navigation items (general appearance, settings button)
  • Indicate the currently selected workspace to screen readers, and indicate the relationship as a list container
  • Indicate the currently selected thread to screen readers, and indicate the relationship as a list container
  • Label copy and thumb up/down buttons in a chat
  • Label stop generating button

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1023 **Author:** [@cartertemm](https://github.com/cartertemm) **Created:** 4/2/2024 **Status:** ✅ Merged **Merged:** 4/3/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1022-bug-screen-reader-labels` --- ### 📝 Commits (6) - [`0e7c030`](https://github.com/Mintplex-Labs/anything-llm/commit/0e7c030440764c22835c9d11fd35e009bc8ea126) Add accessible labels for back and continue buttons in onboarding flow - [`3270e08`](https://github.com/Mintplex-Labs/anything-llm/commit/3270e0826b6936dff1e3c9a02a88c021b0c4d3f6) Add accessible label to stop generating button - [`70314ae`](https://github.com/Mintplex-Labs/anything-llm/commit/70314ae7fa96d120a057966f181d1e1acbb3fdfc) Accessible labels for chat history actions (thumb up/down and copy) - [`1251283`](https://github.com/Mintplex-Labs/anything-llm/commit/12512834bdd14ffaabfa6d86e87eb3a5ca61ed7b) Accessible labels for social links in footer - [`6a80b96`](https://github.com/Mintplex-Labs/anything-llm/commit/6a80b96c8c053f1d95df45a152576e9cee8ecc27) Accessible labels for home and settings links - [`add7dfc`](https://github.com/Mintplex-Labs/anything-llm/commit/add7dfc2df33a0a04cbf8e83a2b86c60f4cb6a06) * Accessible labels for home, show sidebar (mobile), and workspace and thread lists. ### 📊 Changes **9 files changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Footer/index.jsx` (+3 -0) 📝 `frontend/src/components/SettingsButton/index.jsx` (+2 -0) 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/ThreadItem/index.jsx` (+6 -1) 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx` (+1 -1) 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx` (+5 -2) 📝 `frontend/src/components/Sidebar/index.jsx` (+2 -0) 📝 `frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/HistoricalMessage/Actions/index.jsx` (+2 -0) 📝 `frontend/src/components/WorkspaceChat/ChatContainer/PromptInput/StopGenerationButton/index.jsx` (+1 -0) 📝 `frontend/src/pages/OnboardingFlow/Steps/index.jsx` (+2 -0) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues resolves #1022 ### What is in this change? Invisible changes to the UI that offer considerable improvements to the accessibility of the application for screen reader users. Most of the buttons are now spoken properly, and related controls have been grouped to make it possible to quickly reach the workspace and threads lists. ### Additional Information Full list of changes: * Label the back button on the onboarding screen * Label the continue button on the onboarding screen * Label the social links, which are currently only represented by images * Label some of the navigation items (general appearance, settings button) * Indicate the currently selected workspace to screen readers, and indicate the relationship as a list container * Indicate the currently selected thread to screen readers, and indicate the relationship as a list container * Label copy and thumb up/down buttons in a chat * Label stop generating button ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:01 -05:00
yindo closed this issue 2026-02-22 18:34:02 -05:00
yindo changed title from [PR #1023] [BUG]: Many controls lack screen reader labels to [PR #1023] [MERGED] [BUG]: Many controls lack screen reader labels 2026-06-05 15:14:02 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?