Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1135] [MERGED] Warn user when changing embedder with current progress already #3598

New Issue
Closed
opened 2026-02-22 18:34:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:06 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1135
Author: @timothycarambat
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @timothycarambat

Base: master ← Head: 1131-warn-embed-model-change

📝 Commits (2)

  • adf3ead Warn user when changing embedder with current progress already
  • e3a4995 update comment

📊 Changes

3 files changed (+74 additions, -44 deletions)

View changed files

📝 frontend/src/pages/GeneralSettings/EmbeddingPreference/index.jsx (+57 -43)
📝 server/models/systemSettings.js (+3 -1)
📝 server/utils/files/index.js (+14 -0)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1131

What is in this change?

Warn the user when they are changing their embedding provider or model from a previous engine/model and they have currently embedded documents or even cached embeddings as the incongruent dimensions between cache and new embeddings (query or embed) will cause failed embeddings or failed chats on cached embeddings used in workspaces.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1135 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1131-warn-embed-model-change` --- ### 📝 Commits (2) - [`adf3ead`](https://github.com/Mintplex-Labs/anything-llm/commit/adf3ead6cfbef24b2184211e002a9f782d933109) Warn user when changing embedder with current progress already - [`e3a4995`](https://github.com/Mintplex-Labs/anything-llm/commit/e3a49955a4a0559bb2839a956d3f7ff4d5caabf9) update comment ### 📊 Changes **3 files changed** (+74 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/GeneralSettings/EmbeddingPreference/index.jsx` (+57 -43) 📝 `server/models/systemSettings.js` (+3 -1) 📝 `server/utils/files/index.js` (+14 -0) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1131 ### What is in this change? Warn the user when they are changing their embedding provider or model from a previous engine/model and they have currently embedded documents or even _cached_ embeddings as the incongruent dimensions between cache and new embeddings (query or embed) will cause failed embeddings or failed chats on cached embeddings used in workspaces. ### Additional Information ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:06 -05:00
yindo closed this issue 2026-02-22 18:34:07 -05:00
yindo changed title from [PR #1135] Warn user when changing embedder with current progress already to [PR #1135] [MERGED] Warn user when changing embedder with current progress already 2026-06-05 15:14:14 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?