Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1238] [MERGED] Adjust how text is split depending on input type #3629

New Issue
Closed
opened 2026-02-22 18:34:10 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:10 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1238
Author: @timothycarambat
Created: 4/30/2024
Status: ✅ Merged
Merged: 4/30/2024
Merged by: @timothycarambat

Base: master ← Head: 1230-text-input-embed-chunking-bug

📝 Commits (1)

  • 5f66e2a Adjust how text is split depending on input type

📊 Changes

6 files changed (+18 additions, -6 deletions)

View changed files

📝 server/utils/EmbeddingEngines/azureOpenAi/index.js (+3 -1)
📝 server/utils/EmbeddingEngines/lmstudio/index.js (+3 -1)
📝 server/utils/EmbeddingEngines/localAi/index.js (+3 -1)
📝 server/utils/EmbeddingEngines/native/index.js (+3 -1)
📝 server/utils/EmbeddingEngines/ollama/index.js (+3 -1)
📝 server/utils/EmbeddingEngines/openAi/index.js (+3 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1230

What is in this change?

Fixes issue where prompt would be split erroneously by the embedder during vector search resulting in worse semantic similarity.

Additional Information

Important

We need to also ensure the prompt given (or chunks of prompts) are not longer than the embedder model's max length or prompt search will crash

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1238 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 4/30/2024 **Status:** ✅ Merged **Merged:** 4/30/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1230-text-input-embed-chunking-bug` --- ### 📝 Commits (1) - [`5f66e2a`](https://github.com/Mintplex-Labs/anything-llm/commit/5f66e2af5cf1f5107d6b529a4780b8711f5b8e94) Adjust how text is split depending on input type ### 📊 Changes **6 files changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/EmbeddingEngines/azureOpenAi/index.js` (+3 -1) 📝 `server/utils/EmbeddingEngines/lmstudio/index.js` (+3 -1) 📝 `server/utils/EmbeddingEngines/localAi/index.js` (+3 -1) 📝 `server/utils/EmbeddingEngines/native/index.js` (+3 -1) 📝 `server/utils/EmbeddingEngines/ollama/index.js` (+3 -1) 📝 `server/utils/EmbeddingEngines/openAi/index.js` (+3 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1230 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> Fixes issue where prompt would be split erroneously by the embedder during vector search resulting in worse semantic similarity. ### Additional Information > [!IMPORTANT] > We need to also ensure the prompt given (or chunks of prompts) are not longer than the embedder model's max length or prompt search will crash <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:10 -05:00
yindo closed this issue 2026-02-22 18:34:10 -05:00
yindo changed title from [PR #1238] Adjust how text is split depending on input type to [PR #1238] [MERGED] Adjust how text is split depending on input type 2026-06-05 15:14:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?