Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1250] [MERGED] [FIX] Document pinning does not count in query mode #3633

New Issue
Closed
opened 2026-02-22 18:34:11 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:11 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1250
Author: @shatfield4
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/2/2024
Merged by: @timothycarambat

Base: master ← Head: 1218-document-pinning-does-not-count

📝 Commits (3)

  • e39c4bd if document is pinned, do not give queryRefusalResponse message
  • 944fdfb Merge branch 'master' into 1218-document-pinning-does-not-count
  • f48da4f forgot embed.js patch

📊 Changes

3 files changed (+17 additions, -5 deletions)

View changed files

📝 server/utils/chats/embed.js (+5 -1)
📝 server/utils/chats/index.js (+6 -2)
📝 server/utils/chats/stream.js (+6 -2)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1218

What is in this change?

  • Add a check to make sure we do not give the query refusal message if there is a pinned document
  • Would previously ignore the pinned document when in query mode if no other documents were embedded

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1250 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1218-document-pinning-does-not-count` --- ### 📝 Commits (3) - [`e39c4bd`](https://github.com/Mintplex-Labs/anything-llm/commit/e39c4bd9e6ce27e648ba7e8821e454d416a2ce4b) if document is pinned, do not give queryRefusalResponse message - [`944fdfb`](https://github.com/Mintplex-Labs/anything-llm/commit/944fdfb266872a4808f7e1b3324ec14328912fdf) Merge branch 'master' into 1218-document-pinning-does-not-count - [`f48da4f`](https://github.com/Mintplex-Labs/anything-llm/commit/f48da4f4a165c4250ee998450ddc508b2eb44ee8) forgot embed.js patch ### 📊 Changes **3 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/chats/embed.js` (+5 -1) 📝 `server/utils/chats/index.js` (+6 -2) 📝 `server/utils/chats/stream.js` (+6 -2) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1218 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Add a check to make sure we do not give the query refusal message if there is a pinned document - Would previously ignore the pinned document when in query mode if no other documents were embedded ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:11 -05:00
yindo closed this issue 2026-02-22 18:34:11 -05:00
yindo changed title from [PR #1250] [FIX] Document pinning does not count in query mode to [PR #1250] [MERGED] [FIX] Document pinning does not count in query mode 2026-06-05 15:14:25 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?