Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1740] [CLOSED] [FIX] Toggling on "Users can delete workspaces" does not take effect #3765

New Issue
Closed
opened 2026-02-22 18:34:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1740
Author: @shatfield4
Created: 6/21/2024
Status: ❌ Closed

Base: master ← Head: 1536-bug-toggling-on-users-can-delete-workspaces-does-not-take-effect

📝 Commits (4)

  • 0e5e742 wip fix delete workspace in default role
  • 2325535 fix users not being able to delete workspaces in default role when setting is enabled
  • b532cf2 Merge branch 'master' into 1536-bug-toggling-on-users-can-delete-workspaces-does-not-take-effect
  • cf68054 update translations and copy for delete workspace

📊 Changes

12 files changed (+83 additions, -34 deletions)

View changed files

📝 frontend/src/App.jsx (+1 -1)
📝 frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx (+28 -22)
📝 frontend/src/locales/en/common.js (+3 -0)
📝 frontend/src/locales/es/common.js (+3 -0)
📝 frontend/src/locales/fr/common.js (+3 -0)
📝 frontend/src/locales/ru/common.js (+3 -0)
📝 frontend/src/locales/zh/common.js (+2 -0)
📝 frontend/src/pages/WorkspaceSettings/GeneralAppearance/DeleteWorkspace/index.jsx (+15 -8)
📝 frontend/src/pages/WorkspaceSettings/GeneralAppearance/WorkspacePfp/index.jsx (+1 -1)
📝 frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx (+9 -0)
📝 frontend/src/pages/WorkspaceSettings/index.jsx (+3 -0)
📝 server/endpoints/workspaces.js (+12 -2)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1536

What is in this change?

  • Fix bug where users were not able to delete workspaces with default role when setting was enebaled
  • The "Users can delete workspaces" toggle now hides and shows the settings icon for default users when enabled
  • Tested for single and multi-user modes

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1740 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 6/21/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1536-bug-toggling-on-users-can-delete-workspaces-does-not-take-effect` --- ### 📝 Commits (4) - [`0e5e742`](https://github.com/Mintplex-Labs/anything-llm/commit/0e5e742c27637a2ec9a092bbe721ac7feea3baad) wip fix delete workspace in default role - [`2325535`](https://github.com/Mintplex-Labs/anything-llm/commit/23255359c7767b9b4d327e70cc0269483f0d57b5) fix users not being able to delete workspaces in default role when setting is enabled - [`b532cf2`](https://github.com/Mintplex-Labs/anything-llm/commit/b532cf27358ca8caf1ad1291ac905c498e18290a) Merge branch 'master' into 1536-bug-toggling-on-users-can-delete-workspaces-does-not-take-effect - [`cf68054`](https://github.com/Mintplex-Labs/anything-llm/commit/cf68054107d994134dfcda89d362b13cd24093fe) update translations and copy for delete workspace ### 📊 Changes **12 files changed** (+83 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/App.jsx` (+1 -1) 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx` (+28 -22) 📝 `frontend/src/locales/en/common.js` (+3 -0) 📝 `frontend/src/locales/es/common.js` (+3 -0) 📝 `frontend/src/locales/fr/common.js` (+3 -0) 📝 `frontend/src/locales/ru/common.js` (+3 -0) 📝 `frontend/src/locales/zh/common.js` (+2 -0) 📝 `frontend/src/pages/WorkspaceSettings/GeneralAppearance/DeleteWorkspace/index.jsx` (+15 -8) 📝 `frontend/src/pages/WorkspaceSettings/GeneralAppearance/WorkspacePfp/index.jsx` (+1 -1) 📝 `frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx` (+9 -0) 📝 `frontend/src/pages/WorkspaceSettings/index.jsx` (+3 -0) 📝 `server/endpoints/workspaces.js` (+12 -2) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1536 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fix bug where users were not able to delete workspaces with default role when setting was enebaled - The "Users can delete workspaces" toggle now hides and shows the settings icon for default users when enabled - Tested for single and multi-user modes ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:27 -05:00
yindo closed this issue 2026-02-22 18:34:27 -05:00
yindo changed title from [PR #1740] [FIX] Toggling on "Users can delete workspaces" does not take effect to [PR #1740] [CLOSED] [FIX] Toggling on "Users can delete workspaces" does not take effect 2026-06-05 15:15:06 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3765
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?