Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1808] [MERGED] Update bgworker to use fork instead of worker_thread #3787

New Issue
Closed
opened 2026-02-22 18:34:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:30 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1808
Author: @timothycarambat
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @timothycarambat

Base: master ← Head: chore/update-to-custom-bree

📝 Commits (1)

  • 99ee702 Update bgworker to use fork instead of worker_thread

📊 Changes

4 files changed (+25 additions, -23 deletions)

View changed files

📝 server/jobs/helpers/index.js (+2 -2)
📝 server/package.json (+1 -1)
📝 server/utils/BackgroundWorkers/index.js (+3 -1)
📝 server/yarn.lock (+19 -19)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

What is in this change?

  • Migrate to @mintplex-labs/bree so we can use fork for jobs instead of worker_threads as the bg workers can sometimes reregister modules and contaminate the heap of the main backend thread. While this does consume more resources, it does ensure total resource isolation.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1808 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `chore/update-to-custom-bree` --- ### 📝 Commits (1) - [`99ee702`](https://github.com/Mintplex-Labs/anything-llm/commit/99ee7020bf7dc4abf0adf1686ec327b178fa2a40) Update bgworker to use `fork` instead of `worker_thread` ### 📊 Changes **4 files changed** (+25 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `server/jobs/helpers/index.js` (+2 -2) 📝 `server/package.json` (+1 -1) 📝 `server/utils/BackgroundWorkers/index.js` (+3 -1) 📝 `server/yarn.lock` (+19 -19) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [x] 🔨 chore - [ ] 📝 docs ### What is in this change? - Migrate to [@mintplex-labs/bree](https://www.npmjs.com/package/@mintplex-labs/bree) so we can use `fork` for jobs instead of `worker_threads` as the bg workers can sometimes reregister modules and contaminate the heap of the main backend thread. While this does consume more resources, it does ensure total resource isolation. <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:30 -05:00
yindo closed this issue 2026-02-22 18:34:30 -05:00
yindo changed title from [PR #1808] Update bgworker to use `fork` instead of `worker_thread` to [PR #1808] [MERGED] Update bgworker to use `fork` instead of `worker_thread` 2026-06-05 15:15:13 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?