Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1848] [MERGED] [FIX] Fix manual input model pref for agents #3797

New Issue
Closed
opened 2026-02-22 18:34:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1848
Author: @shatfield4
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/11/2024
Merged by: @timothycarambat

Base: master ← Head: 1840-why-am-i-using-agent-to-access-gpt35-instead-of-my-local-modelbug

📝 Commits (3)

  • f2b44c2 patch llm providers that have manual inputs for model pref
  • edacf97 refactor agent model fallback
  • 0f329e4 patch log on startup

📊 Changes

4 files changed (+73 additions, -6 deletions)

View changed files

📝 frontend/src/pages/WorkspaceSettings/AgentConfig/AgentModelSelection/index.jsx (+24 -1)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/ChatModelSelection/index.jsx (+1 -0)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/index.jsx (+19 -2)
📝 server/utils/agents/index.js (+29 -3)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1840

What is in this change?

  • On some LLM providers, the user needs to manually enter the model pref name and when doing this in the agent settings, it does not update the agentModel column in the workspace table so we need to grab the correct model from the environment and inject it into the agent on provider setup
  • This fixes a bug where a user is using the Generic OpenAI LLM provider model and it never updates to the correct model (would always default back to gpt-3.5-turbo)

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1848 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/11/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1840-why-am-i-using-agent-to-access-gpt35-instead-of-my-local-modelbug` --- ### 📝 Commits (3) - [`f2b44c2`](https://github.com/Mintplex-Labs/anything-llm/commit/f2b44c27ad00afefae322bbfd7d94069441acc15) patch llm providers that have manual inputs for model pref - [`edacf97`](https://github.com/Mintplex-Labs/anything-llm/commit/edacf979235962cee09aae49d7789d18d91bae50) refactor agent model fallback - [`0f329e4`](https://github.com/Mintplex-Labs/anything-llm/commit/0f329e48625b5206c150497bd1b41c4251e7b6ab) patch log on startup ### 📊 Changes **4 files changed** (+73 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/WorkspaceSettings/AgentConfig/AgentModelSelection/index.jsx` (+24 -1) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/ChatModelSelection/index.jsx` (+1 -0) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/index.jsx` (+19 -2) 📝 `server/utils/agents/index.js` (+29 -3) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1840 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - On some LLM providers, the user needs to manually enter the model pref name and when doing this in the agent settings, it does not update the agentModel column in the workspace table so we need to grab the correct model from the environment and inject it into the agent on provider setup - This fixes a bug where a user is using the Generic OpenAI LLM provider model and it never updates to the correct model (would always default back to gpt-3.5-turbo) ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:31 -05:00
yindo closed this issue 2026-02-22 18:34:31 -05:00
yindo changed title from [PR #1848] [FIX] Fix manual input model pref for agents to [PR #1848] [MERGED] [FIX] Fix manual input model pref for agents 2026-06-05 15:15:17 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3797
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?