Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #1879] [MERGED] [FIX] PDFLoader module bug fix #3807

New Issue
Closed
opened 2026-02-22 18:34:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/1879
Author: @shatfield4
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @timothycarambat

Base: master ← Head: 1878-bug-some-pdf-files-fail-to-upload

📝 Commits (1)

  • dfc6092 use pdf.js by importing it from pdf-parse and fix custom PDFLoader module

📊 Changes

1 file changed (+75 additions, -40 deletions)

View changed files

📝 collector/processSingleFile/convert/asPDF/PDFLoader/index.js (+75 -40)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1878

What is in this change?

  • Fixes a bug where some files that are uploaded to the collector would throw a bad XRef entry error and crash the collector
  • Update the logic of the PDFLoader to use the same logic as the LangChain PDFLoader with the abstractions ripped out
  • No longer use pdf-parse directly for parsing PDF files due to it not having as robust error handling as using pdf.js the same way the LangChain PDFLoader does it

NOTE: The LangChain PDFLoader imports pdf-parse as an easy way to access pdf.js since pdf-parse has multiple versions of pdf.js bundled in the library

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/1879 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `1878-bug-some-pdf-files-fail-to-upload` --- ### 📝 Commits (1) - [`dfc6092`](https://github.com/Mintplex-Labs/anything-llm/commit/dfc6092cd4623cbb9db491ae326cfc76435e74f7) use pdf.js by importing it from pdf-parse and fix custom PDFLoader module ### 📊 Changes **1 file changed** (+75 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `collector/processSingleFile/convert/asPDF/PDFLoader/index.js` (+75 -40) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #1878 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fixes a bug where some files that are uploaded to the collector would throw a `bad XRef entry` error and crash the collector - Update the logic of the PDFLoader to use the same logic as the LangChain PDFLoader with the abstractions ripped out - No longer use `pdf-parse` directly for parsing PDF files due to it not having as robust error handling as using `pdf.js` the same way the LangChain PDFLoader does it **NOTE: The LangChain PDFLoader imports `pdf-parse` as an easy way to access `pdf.js` since `pdf-parse` has multiple versions of `pdf.js` bundled in the library** ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:32 -05:00
yindo closed this issue 2026-02-22 18:34:32 -05:00
yindo changed title from [PR #1879] [FIX] PDFLoader module bug fix to [PR #1879] [MERGED] [FIX] PDFLoader module bug fix 2026-06-05 15:15:19 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3807
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?