Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2222] [MERGED] Feature/use escape key to close documents modal #3921

New Issue
Closed
opened 2026-02-22 18:34:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:46 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2222
Author: @timothycarambat
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @timothycarambat

Base: master ← Head: feature/use-escape-key-to-close-documents-modal

📝 Commits (3)

  • 66fffcb Add ability to use Esc keypress to close modal for documents
  • 2aea981 Merge branch 'master' of github.com:Mintplex-Labs/anything-llm into feature/use-escape-key-to-close-documents-modal
  • 190bf5a move escape close to hook

📊 Changes

1 file changed (+17 additions, -4 deletions)

View changed files

📝 frontend/src/components/Modals/ManageWorkspace/index.jsx (+17 -4)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2221 by @MrSimonC
resolves #2220

What is in this change?

This pull request adds the ability to close the modal dialogue for selecting documents in workspaces using the Escape key on the keyboard. Specifically, the changes include:

  • Adding an event listener to the modal dialogue to listen for the Escape key press event.
  • Closing the modal dialogue when the Escape key is pressed.

This change provides an additional option for users to dismiss the modal, improving the overall user experience and efficiency.

Additional Information

This change addresses a feature request to improve the workflow for users who work with multiple workspaces and need to quickly switch between them. By allowing the Escape key to close the modal, users can reduce mouse movement and streamline their workflow. This change does not introduce any breaking changes or affect existing functionality.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2222 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `feature/use-escape-key-to-close-documents-modal` --- ### 📝 Commits (3) - [`66fffcb`](https://github.com/Mintplex-Labs/anything-llm/commit/66fffcbeceb43bf867248b9c25347f5d6fdb21c4) Add ability to use Esc keypress to close modal for documents - [`2aea981`](https://github.com/Mintplex-Labs/anything-llm/commit/2aea981fc688ad2f1a8b4d3f017afab30a799e38) Merge branch 'master' of github.com:Mintplex-Labs/anything-llm into feature/use-escape-key-to-close-documents-modal - [`190bf5a`](https://github.com/Mintplex-Labs/anything-llm/commit/190bf5a60281b9cc677ce8d1d894da590580fa48) move escape close to hook ### 📊 Changes **1 file changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Modals/ManageWorkspace/index.jsx` (+17 -4) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2221 by @MrSimonC resolves #2220 ### What is in this change? This pull request adds the ability to close the modal dialogue for selecting documents in workspaces using the Escape key on the keyboard. Specifically, the changes include: - Adding an event listener to the modal dialogue to listen for the Escape key press event. - Closing the modal dialogue when the Escape key is pressed. This change provides an additional option for users to dismiss the modal, improving the overall user experience and efficiency. ### Additional Information This change addresses a feature request to improve the workflow for users who work with multiple workspaces and need to quickly switch between them. By allowing the Escape key to close the modal, users can reduce mouse movement and streamline their workflow. This change does not introduce any breaking changes or affect existing functionality. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:46 -05:00
yindo closed this issue 2026-02-22 18:34:46 -05:00
yindo changed title from [PR #2222] Feature/use escape key to close documents modal to [PR #2222] [MERGED] Feature/use escape key to close documents modal 2026-06-05 15:15:55 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3921
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?