Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2276] [MERGED] Make userId actually optional for workspaceThread endpoint #3943

New Issue
Closed
opened 2026-02-22 18:34:49 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:49 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2276
Author: @timothycarambat
Created: 9/12/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @timothycarambat

Base: master ← Head: 2272-userId-optional-for-threads

📝 Commits (1)

  • 9449ce4 Make userId actually optional for workspaceThread endpoint

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 server/endpoints/api/workspaceThread/index.js (+7 -5)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2272

What is in this change?

If a user uses the UI automation endpoint for threads but passes in a userId and is not in mutli-user mode the foreign key constraint fails for new threads. We should instead force userId to null when not in multi-user mode as otherwise it would pass

Additional Information

  • We are not force checking the provided userId given as to be valid (but would fail in upsert anyway if not a valid user ID)

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2276 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 9/12/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2272-userId-optional-for-threads` --- ### 📝 Commits (1) - [`9449ce4`](https://github.com/Mintplex-Labs/anything-llm/commit/9449ce4029a7668e2ba2979f22c51e74a5d582f3) Make `userId` actually optional for workspaceThread endpoint ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server/endpoints/api/workspaceThread/index.js` (+7 -5) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2272 ### What is in this change? If a user uses the UI automation endpoint for threads but passes in a `userId` and is _not in mutli-user mode_ the foreign key constraint fails for new threads. We should instead force `userId` to null when not in multi-user mode as otherwise it would pass <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information - We are not force checking the provided userId given as to be valid (but would fail in upsert anyway if not a valid user ID) <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [ ] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated - [ ] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:49 -05:00
yindo closed this issue 2026-02-22 18:34:49 -05:00
yindo changed title from [PR #2276] Make `userId` actually optional for workspaceThread endpoint to [PR #2276] [MERGED] Make `userId` actually optional for workspaceThread endpoint 2026-06-05 15:16:00 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3943
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?