Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2485] [CLOSED] Fix upload in dev API garbled Chinese chars #4008

New Issue
Closed
opened 2026-02-22 18:34:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:57 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2485
Author: @shatfield4
Created: 10/15/2024
Status: ❌ Closed

Base: master ← Head: 2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name

📝 Commits (4)

  • 02b0cc1 fix garbled chinese chars in filename when uploading via dev api
  • ffef473 lint
  • 130f914 Merge branch 'master' into 2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name
  • 6987d67 Merge branch 'master' into 2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 server/utils/files/multer.js (+4 -3)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2474

What is in this change?

  • Fix a bug where if a file with Chinese character is uploaded via the developer API (/v1/document/upload route) it would save the file with garbled characters instead of the correct Chinese characters
  • Fixed by doing a decodeURIComponent in the multer middleware before converting to utf8

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2485 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 10/15/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name` --- ### 📝 Commits (4) - [`02b0cc1`](https://github.com/Mintplex-Labs/anything-llm/commit/02b0cc1b68266a23eaa4a4d2858bad308ab75b71) fix garbled chinese chars in filename when uploading via dev api - [`ffef473`](https://github.com/Mintplex-Labs/anything-llm/commit/ffef473aa2c40f0564c1da665014b6452b5fc9d5) lint - [`130f914`](https://github.com/Mintplex-Labs/anything-llm/commit/130f91409c73b20d5d4bde0dae41156a41da76e5) Merge branch 'master' into 2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name - [`6987d67`](https://github.com/Mintplex-Labs/anything-llm/commit/6987d67761b50a528c5014f6f7493639d8bfbaa8) Merge branch 'master' into 2474-bug-use-postman-to-post-api-v1documentupload-with-chinese-file-name-api-will-response-garbled-title-name ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/files/multer.js` (+4 -3) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2474 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fix a bug where if a file with Chinese character is uploaded via the developer API (`/v1/document/upload` route) it would save the file with garbled characters instead of the correct Chinese characters - Fixed by doing a `decodeURIComponent` in the multer middleware before converting to utf8 ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:57 -05:00
yindo closed this issue 2026-02-22 18:34:57 -05:00
yindo changed title from [PR #2485] Fix upload in dev API garbled Chinese chars to [PR #2485] [CLOSED] Fix upload in dev API garbled Chinese chars 2026-06-05 15:16:20 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?