Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2495] [MERGED] Handle non-ascii characters in single and bulk link scraper URLs #4013

New Issue
Closed
opened 2026-02-22 18:34:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:57 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2495
Author: @shatfield4
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @timothycarambat

Base: master ← Head: 2493-bug-fetch-url-with-chinese-will-cause-error-uploading-link-a-processing-error-occurred

📝 Commits (1)

  • 4f56269 handle non-ascii characters in urls

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 collector/processLink/convert/generic.js (+2 -1)
📝 collector/utils/extensions/WebsiteDepth/index.js (+2 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2493

What is in this change?

  • Handle non-ascii characters in URLs for the single link scraper and bulk link scraper
  • Chinese characters or any other non-ascii characters are converted into an extremely long string which would throw the error ENAMETOOLONG
  • We fix this now by doing a decodeURIComponent on url.pathname to handle the non-ascii characters

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2495 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2493-bug-fetch-url-with-chinese-will-cause-error-uploading-link-a-processing-error-occurred` --- ### 📝 Commits (1) - [`4f56269`](https://github.com/Mintplex-Labs/anything-llm/commit/4f562699e37c990593a69fb8a018b2ffc762cb5e) handle non-ascii characters in urls ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `collector/processLink/convert/generic.js` (+2 -1) 📝 `collector/utils/extensions/WebsiteDepth/index.js` (+2 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2493 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Handle non-ascii characters in URLs for the single link scraper and bulk link scraper - Chinese characters or any other non-ascii characters are converted into an extremely long string which would throw the error `ENAMETOOLONG` - We fix this now by doing a `decodeURIComponent` on url.pathname to handle the non-ascii characters ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:57 -05:00
yindo closed this issue 2026-02-22 18:34:57 -05:00
yindo changed title from [PR #2495] Handle non-ascii characters in single and bulk link scraper URLs to [PR #2495] [MERGED] Handle non-ascii characters in single and bulk link scraper URLs 2026-06-05 15:16:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4013
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?