Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2512] [MERGED] Feature/thread creation slug name #4019

New Issue
Closed
opened 2026-02-22 18:34:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2512
Author: @timothycarambat
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @timothycarambat

Base: master ← Head: feature/thread-creation-slug-name

📝 Commits (4)

  • c9ccfad thread creation additional params name and slug, with api
  • 49d09c9 typo fix
  • f2ef298 Rebuild openai Swagger docs
  • 31b7df3 Merge branch 'master' into feature/thread-creation-slug-name

📊 Changes

4 files changed (+45 additions, -11 deletions)

View changed files

📝 .vscode/settings.json (+1 -0)
📝 server/endpoints/api/workspaceThread/index.js (+9 -6)
📝 server/models/workspaceThread.js (+31 -3)
📝 server/swagger/openapi.json (+4 -2)

📄 Description

Pull Request Type

original PR by @abrakadobr

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

closes #2507

What is in this change?

Optional slug and name params for workspace thread creation to use with API.
Adds validation to .new creation to ensure valid field upsert and sluggification of the slug input to prevent breaking the URL when viewed by the user.

Additional Information

Without slug param there is no way to identify thread by some 3rd party uuid4 with api. It's possible to store somewhere additional relation of "3rd party uuid4 - threadSlug", but with having ability of defining thread slug manually - this will be not required - thread slug will be equal to "3rd party uuid" so it will be easy to get required thread.

With thread name definition - it will be easy to use UI as "admin tool for viewing results of api based chats "

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2512 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `feature/thread-creation-slug-name` --- ### 📝 Commits (4) - [`c9ccfad`](https://github.com/Mintplex-Labs/anything-llm/commit/c9ccfad35e77860a549b2f68ff71787431ebd47e) thread creation additional params name and slug, with api - [`49d09c9`](https://github.com/Mintplex-Labs/anything-llm/commit/49d09c9c2b2e94844345fc18c7940983a7f1e942) typo fix - [`f2ef298`](https://github.com/Mintplex-Labs/anything-llm/commit/f2ef2989123e512ddde53616fc785eaf7d7c6d62) Rebuild openai Swagger docs - [`31b7df3`](https://github.com/Mintplex-Labs/anything-llm/commit/31b7df34f98f0aac29636170fd08359c0a069dbb) Merge branch 'master' into feature/thread-creation-slug-name ### 📊 Changes **4 files changed** (+45 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.vscode/settings.json` (+1 -0) 📝 `server/endpoints/api/workspaceThread/index.js` (+9 -6) 📝 `server/models/workspaceThread.js` (+31 -3) 📝 `server/swagger/openapi.json` (+4 -2) </details> ### 📄 Description ### Pull Request Type original PR by @abrakadobr <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> closes #2507 ### What is in this change? Optional slug and name params for workspace thread creation to use with API. Adds validation to `.new` creation to ensure valid field upsert and sluggification of the `slug` input to prevent breaking the URL when viewed by the user. <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information Without slug param there is no way to identify thread by some 3rd party uuid4 with api. It's possible to store somewhere additional relation of "3rd party uuid4 - threadSlug", but with having ability of defining thread slug manually - this will be not required - thread slug will be equal to "3rd party uuid" so it will be easy to get required thread. With thread name definition - it will be easy to use UI as "admin tool for viewing results of api based chats " <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:58 -05:00
yindo closed this issue 2026-02-22 18:34:58 -05:00
yindo changed title from [PR #2512] Feature/thread creation slug name to [PR #2512] [MERGED] Feature/thread creation slug name 2026-06-05 15:16:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?