Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2515] [MERGED] Rework failover agent invocation selection for agent and ephemmeral agent #4021

New Issue
Closed
opened 2026-02-22 18:34:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2515
Author: @timothycarambat
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @timothycarambat

Base: master ← Head: 2514-workspace-agent-fallback

📝 Commits (4)

  • d71c309 Rework failover agent invocation selection for agent and ephemmeral agent
  • 5d53cbd update order of check
  • d5270d6 update order of check
  • e254693 lint

📊 Changes

2 files changed (+90 additions, -52 deletions)

View changed files

📝 server/utils/agents/ephemeral.js (+49 -10)
📝 server/utils/agents/index.js (+41 -42)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2514

What is in this change?

use the explicitly set agentProvider and agentModel combination. No verification is done to confirm the pairing is valid, just that it exists. The API will return any errors anyway.

Fallback to the workspaces chatProvider and chatModel overrides, this at least keeps answers within the same model preference the user-defined for a workspace.

Lastly, attempt to use the LLM_PROVIDER env and its ENV default model. If no ENV preference can be found - assume a static model string that is generally available for the provider. If that cannot be determined - return null and probably exit since most LLM providers do not accept null for model.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2515 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2514-workspace-agent-fallback` --- ### 📝 Commits (4) - [`d71c309`](https://github.com/Mintplex-Labs/anything-llm/commit/d71c3097ce8735fc62035b43f09a2fd4506c5816) Rework failover agent invocation selection for agent and ephemmeral agent - [`5d53cbd`](https://github.com/Mintplex-Labs/anything-llm/commit/5d53cbd5964a1363cd2a967629f70c9e897e7432) update order of check - [`d5270d6`](https://github.com/Mintplex-Labs/anything-llm/commit/d5270d62c51e867b81c493d9ca3e4f2c51d201fe) update order of check - [`e254693`](https://github.com/Mintplex-Labs/anything-llm/commit/e2546933170f1fbfd7cef46c8403b65a3aab3b0e) lint ### 📊 Changes **2 files changed** (+90 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/agents/ephemeral.js` (+49 -10) 📝 `server/utils/agents/index.js` (+41 -42) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2514 ### What is in this change? use the explicitly set agentProvider and agentModel combination. No verification is done to confirm the pairing is valid, just that it exists. The API will return any errors anyway. Fallback to the workspaces chatProvider and chatModel overrides, this at least keeps answers within the same model preference the user-defined for a workspace. Lastly, attempt to use the LLM_PROVIDER env and its ENV default model. If no ENV preference can be found - assume a static model string that is generally available for the provider. If that cannot be determined - return null and probably exit since most LLM providers do not accept null for model. <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:58 -05:00
yindo closed this issue 2026-02-22 18:34:58 -05:00
yindo changed title from [PR #2515] Rework failover agent invocation selection for agent and ephemmeral agent to [PR #2515] [MERGED] Rework failover agent invocation selection for agent and ephemmeral agent 2026-06-05 15:16:25 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4021
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?