Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2560] [MERGED] Allow 127.0.0.1 as valid URL for scraping #4035

New Issue
Closed
opened 2026-02-22 18:35:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:00 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2560
Author: @shatfield4
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @timothycarambat

Base: master ← Head: 2459-bug-bulk-link-scraper-does-not-work-for-localhost-website

📝 Commits (2)

  • 6b3dd37 allow 127.0.0.1 as valid url for scraping
  • 4079b5d update comments and lint

📊 Changes

2 files changed (+16 additions, -3 deletions)

View changed files

📝 collector/extensions/index.js (+1 -2)
📝 collector/utils/url/index.js (+15 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2459

What is in this change?

  • Modify validURL to allow the localhost IP 127.0.0.1
  • Now allows this to be valid for bulk link scraper and single link scraper
  • Send 400 response on failed validURL check to fix frontend hanging on invalid URL

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2560 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2459-bug-bulk-link-scraper-does-not-work-for-localhost-website` --- ### 📝 Commits (2) - [`6b3dd37`](https://github.com/Mintplex-Labs/anything-llm/commit/6b3dd37fad8d4a20f5e46489df0b5aaea14d5d4c) allow 127.0.0.1 as valid url for scraping - [`4079b5d`](https://github.com/Mintplex-Labs/anything-llm/commit/4079b5d1261641208db73fe3a8ae2f73a749e994) update comments and lint ### 📊 Changes **2 files changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `collector/extensions/index.js` (+1 -2) 📝 `collector/utils/url/index.js` (+15 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2459 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Modify validURL to allow the localhost IP `127.0.0.1` - Now allows this to be valid for bulk link scraper and single link scraper - Send 400 response on failed `validURL` check to fix frontend hanging on invalid URL ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:00 -05:00
yindo closed this issue 2026-02-22 18:35:00 -05:00
yindo changed title from [PR #2560] Allow 127.0.0.1 as valid URL for scraping to [PR #2560] [MERGED] Allow 127.0.0.1 as valid URL for scraping 2026-06-05 15:16:28 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?