Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2808] [MERGED] Redirect to default thread on thread deletion #4130

New Issue
Closed
opened 2026-02-22 18:35:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:12 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2808
Author: @shatfield4
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @timothycarambat

Base: master ← Head: 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted

📝 Commits (10+)

  • 7159204 redirect to default thread on thread deletion
  • 1a983dd Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted
  • f5cdc9c reset submodule
  • ffac83b handle redirect on bulk delete thread
  • dcb2cf8 Merge branch '2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted' of github.com:Mintplex-Labs/anything-llm into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted
  • 543467b Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted
  • 73e7f97 redirect on bulk thread delete only if deleted thread is selected
  • 70e35d7 Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted
  • ea3cbc6 redirect only on single delete of active thread
  • 0e499ca lint

📊 Changes

2 files changed (+19 additions, -2 deletions)

View changed files

📝 frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/ThreadItem/index.jsx (+14 -2)
📝 frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx (+5 -0)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2767

What is in this change?

  • Fixes UI/UX issue where on thread deletion, user would still be presented with the page of the deleted thread and sending messages here would throw a 404 error since the thread no longer exists
  • Fixed by redirecting user back to default thread on thread deletion

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2808 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted` --- ### 📝 Commits (10+) - [`7159204`](https://github.com/Mintplex-Labs/anything-llm/commit/7159204735399109c763ab547542c6e600dea4fc) redirect to default thread on thread deletion - [`1a983dd`](https://github.com/Mintplex-Labs/anything-llm/commit/1a983dda412673fe687b0fd528ed77e3890e6017) Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted - [`f5cdc9c`](https://github.com/Mintplex-Labs/anything-llm/commit/f5cdc9c59b56b3b1e3aab16ed6b72814e80aaa6b) reset submodule - [`ffac83b`](https://github.com/Mintplex-Labs/anything-llm/commit/ffac83b0662a068a8866deb97bbe77256cbe78c2) handle redirect on bulk delete thread - [`dcb2cf8`](https://github.com/Mintplex-Labs/anything-llm/commit/dcb2cf8e5f871d1cd2da72cd6fcc2d0e502ba0c5) Merge branch '2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted' of github.com:Mintplex-Labs/anything-llm into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted - [`543467b`](https://github.com/Mintplex-Labs/anything-llm/commit/543467b623c14581ab4941a2e79a9711423cdbc2) Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted - [`73e7f97`](https://github.com/Mintplex-Labs/anything-llm/commit/73e7f97550a12675817745dff8af484eb8ad41a5) redirect on bulk thread delete only if deleted thread is selected - [`70e35d7`](https://github.com/Mintplex-Labs/anything-llm/commit/70e35d75248cd75514e02bdff32b93d38fb7cc70) Merge branch 'master' into 2767-feat-redirect-to-the-default-thread-after-current-thread-is-deleted - [`ea3cbc6`](https://github.com/Mintplex-Labs/anything-llm/commit/ea3cbc6b10687dd6ac21504b383d70d7960f1c38) redirect only on single delete of active thread - [`0e499ca`](https://github.com/Mintplex-Labs/anything-llm/commit/0e499cafa433235f42a3ff0894ed7ed4e697a589) lint ### 📊 Changes **2 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/ThreadItem/index.jsx` (+14 -2) 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx` (+5 -0) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2767 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fixes UI/UX issue where on thread deletion, user would still be presented with the page of the deleted thread and sending messages here would throw a 404 error since the thread no longer exists - Fixed by redirecting user back to default thread on thread deletion ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:12 -05:00
yindo closed this issue 2026-02-22 18:35:12 -05:00
yindo changed title from [PR #2808] Redirect to default thread on thread deletion to [PR #2808] [MERGED] Redirect to default thread on thread deletion 2026-06-05 15:16:58 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?