Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2865] [MERGED] Allow editing of LLM settings from workspace settings #4158

New Issue
Closed
opened 2026-02-22 18:35:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:15 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2865
Author: @shatfield4
Created: 12/17/2024
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @timothycarambat

Base: master ← Head: 2834-bug-generic-openai-llm-provider-can-not-be-edited

📝 Commits (5)

  • e0c5681 wip change workspace llm settings
  • e5da4c6 Merge branch 'master' into 2834-bug-generic-openai-llm-provider-can-not-be-edited
  • 786d76f allow editing of workspace llm and agent config inside workspace settings
  • 054f3c6 lint + put back deleted comment
  • 0c2d6ec Merge branch 'master' into 2834-bug-generic-openai-llm-provider-can-not-be-edited

📊 Changes

3 files changed (+110 additions, -46 deletions)

View changed files

📝 frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx (+55 -23)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/ChatModelSelection/index.jsx (+2 -2)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx (+53 -21)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2834

What is in this change?

  • Inside workspace settings, when an LLM is selected for the workspace LLM provider we now allow users to modify the LLM settings directly from the workspace settings
  • Applied same logic to the agent LLM settings
  • UI tweaks to LLM configuration modal
  • Fixes a bug where using the Generic OpenAI provider is set on first setup then the user is unable to modify it again after saving it
  • A gear icon appears on the selected provider allowing them to configure the settings from the modal

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2865 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2834-bug-generic-openai-llm-provider-can-not-be-edited` --- ### 📝 Commits (5) - [`e0c5681`](https://github.com/Mintplex-Labs/anything-llm/commit/e0c56812b053f078eeddf3d29dad90d93206bdd7) wip change workspace llm settings - [`e5da4c6`](https://github.com/Mintplex-Labs/anything-llm/commit/e5da4c6dd46b9933b597e84f74217bbd1c5f50c2) Merge branch 'master' into 2834-bug-generic-openai-llm-provider-can-not-be-edited - [`786d76f`](https://github.com/Mintplex-Labs/anything-llm/commit/786d76f302459936da34cb69fb8a42573cdb75ba) allow editing of workspace llm and agent config inside workspace settings - [`054f3c6`](https://github.com/Mintplex-Labs/anything-llm/commit/054f3c6e0f7a30221b22778fb6598cdfa5362223) lint + put back deleted comment - [`0c2d6ec`](https://github.com/Mintplex-Labs/anything-llm/commit/0c2d6ecba3d8c94910b5ff5fa44a8368289a1177) Merge branch 'master' into 2834-bug-generic-openai-llm-provider-can-not-be-edited ### 📊 Changes **3 files changed** (+110 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/WorkspaceSettings/AgentConfig/AgentLLMSelection/AgentLLMItem/index.jsx` (+55 -23) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/ChatModelSelection/index.jsx` (+2 -2) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx` (+53 -21) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2834 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Inside workspace settings, when an LLM is selected for the workspace LLM provider we now allow users to modify the LLM settings directly from the workspace settings - Applied same logic to the agent LLM settings - UI tweaks to LLM configuration modal - Fixes a bug where using the Generic OpenAI provider is set on first setup then the user is unable to modify it again after saving it - A gear icon appears on the selected provider allowing them to configure the settings from the modal ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:15 -05:00
yindo closed this issue 2026-02-22 18:35:15 -05:00
yindo changed title from [PR #2865] Allow editing of LLM settings from workspace settings to [PR #2865] [MERGED] Allow editing of LLM settings from workspace settings 2026-06-05 15:17:08 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?