Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2986] [MERGED] Fix similarity score bug in lance/chroma dbs #4189

New Issue
Closed
opened 2026-02-22 18:35:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:19 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2986
Author: @shatfield4
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @timothycarambat

Base: master ← Head: 2937-bug-vector-search-using-api

📝 Commits (2)

  • fdb9e95 fix similarity score bug in lance/chroma dbs
  • 8064e03 batch lower bound case

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 server/utils/vectorDbProviders/chroma/index.js (+1 -1)
📝 server/utils/vectorDbProviders/lance/index.js (+1 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2937

What is in this change?

  • Fix a bug where if there is an exact match in Lance or ChromaDB from the vector search (distance = 0) then similarity would be 0 and no result would be found
  • Fixed by checking if distance <= 0 -> returns 1 as similarity score which means it was a perfect match
  • It was previously distance <= 0 -> returns 0 for similarity
  • Also fixed if (distance >= 1.0) return 0; because if distance should always be a value between 0 and 1 and if distance is greater than 1 then similarity should be 0

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2986 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2937-bug-vector-search-using-api` --- ### 📝 Commits (2) - [`fdb9e95`](https://github.com/Mintplex-Labs/anything-llm/commit/fdb9e953228bacedf7dfb78b1239e2c7b696355a) fix similarity score bug in lance/chroma dbs - [`8064e03`](https://github.com/Mintplex-Labs/anything-llm/commit/8064e0392d4f3f2d3463c536e778cd0aa658bfbb) batch lower bound case ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/vectorDbProviders/chroma/index.js` (+1 -1) 📝 `server/utils/vectorDbProviders/lance/index.js` (+1 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2937 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fix a bug where if there is an exact match in Lance or ChromaDB from the vector search (distance = 0) then similarity would be 0 and no result would be found - Fixed by checking if `distance <= 0` -> returns `1` as similarity score which means it was a perfect match - It was previously `distance <= 0` -> returns `0` for similarity - Also fixed `if (distance >= 1.0) return 0;` because if distance should always be a value between 0 and 1 and if distance is greater than 1 then similarity should be 0 ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:19 -05:00
yindo closed this issue 2026-02-22 18:35:19 -05:00
yindo changed title from [PR #2986] Fix similarity score bug in lance/chroma dbs to [PR #2986] [MERGED] Fix similarity score bug in lance/chroma dbs 2026-06-05 15:17:17 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4189
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?