Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #3284] [CLOSED] Allow manager to view roles (workspace) #4258

New Issue
Closed
opened 2026-02-22 18:35:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:28 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/3284
Author: @timothycarambat
Created: 2/19/2025
Status: ❌ Closed

Base: master ← Head: 3282-manager-view-models-workspace

📝 Commits (5)

  • 11a4bab Allow manager to view roles (workspace)
  • 382baab add role check to persist API change
  • d466d41 hide all nonconfigured llms from manager in ws settings
  • 165d651 lint
  • 8dad9b5 Merge branch 'master' into 3282-manager-view-models-workspace

📊 Changes

4 files changed (+136 additions, -54 deletions)

View changed files

📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx (+36 -9)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/index.jsx (+23 -6)
📝 server/endpoints/system.js (+3 -2)
📝 server/utils/helpers/customModels.js (+74 -37)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #3282

What is in this change?

  • Allow the manager role to view the models in a dropdown while on workspace settings.
  • Additional security on customModels to only persist a passed ApiKey when the role is null (no auth mode) or the role is explicitly ROLE.admin. null role is okay here since to get to this function the middleware does the proper auth checks.

TODO:

  • If I am a manager and I attempt to pick an LLM that has not been configured, the credential modal should not appear since that update will fail and the details will not persist.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/3284 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 2/19/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `3282-manager-view-models-workspace` --- ### 📝 Commits (5) - [`11a4bab`](https://github.com/Mintplex-Labs/anything-llm/commit/11a4bab002b574e5935ee8068e154e613a735dd6) Allow manager to view roles (workspace) - [`382baab`](https://github.com/Mintplex-Labs/anything-llm/commit/382baabb1732dc27e411c05c6ec210f1c8001b1e) add role check to persist API change - [`d466d41`](https://github.com/Mintplex-Labs/anything-llm/commit/d466d41cf3a70496fe02e0e8bfe3c36be1372e84) hide all nonconfigured llms from manager in ws settings - [`165d651`](https://github.com/Mintplex-Labs/anything-llm/commit/165d651bc2ac1bbd276ba2d06c7c6c399c46bed6) lint - [`8dad9b5`](https://github.com/Mintplex-Labs/anything-llm/commit/8dad9b553f1fd72c791ee830c6a9ba4888b96b5e) Merge branch 'master' into 3282-manager-view-models-workspace ### 📊 Changes **4 files changed** (+136 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/WorkspaceLLMItem/index.jsx` (+36 -9) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/WorkspaceLLMSelection/index.jsx` (+23 -6) 📝 `server/endpoints/system.js` (+3 -2) 📝 `server/utils/helpers/customModels.js` (+74 -37) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #3282 ### What is in this change? - Allow the manager role to view the models in a dropdown while on workspace settings. - Additional security on `customModels` to only persist a passed ApiKey when the role is `null` (no auth mode) or the role is explicitly `ROLE.admin`. `null` role is okay here since to get to this function the middleware does the proper auth checks. TODO: - [x] If I am a manager and I attempt to pick an LLM that has not been configured, the credential modal should not appear since that update will fail and the details will not persist. <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:28 -05:00
yindo changed title from [PR #3284] Allow manager to view roles (workspace) to [PR #3284] [CLOSED] Allow manager to view roles (workspace) 2026-06-05 15:17:38 -04:00
yindo closed this issue 2026-06-05 15:17:39 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4258
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?