Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #3773] [MERGED] Fix/dom nesting warnings #4395

New Issue
Closed
opened 2026-02-22 18:35:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:44 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/3773
Author: @17ColinMiPerry
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/6/2025
Merged by: @timothycarambat

Base: master ← Head: fix/dom-nesting-warnings

📝 Commits (3)

📊 Changes

4 files changed (+25 additions, -27 deletions)

View changed files

📝 frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx (+17 -16)
📝 frontend/src/pages/WorkspaceSettings/ChatSettings/ChatPromptSettings/index.jsx (+4 -7)
📝 frontend/src/pages/WorkspaceSettings/GeneralAppearance/SuggestedChatMessages/index.jsx (+2 -2)
📝 frontend/src/pages/WorkspaceSettings/VectorDatabase/VectorCount/index.jsx (+2 -2)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #3772

What is in this change?

In ActiveWorkspaces, the nested tag was replaced with a button tag with onClick behavior to handle navigation. Client-side routing performance is maintained.
In SuggestedChatMessages,

tag was replaced with a

tag to prevent the div in p warning.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/3773 **Author:** [@17ColinMiPerry](https://github.com/17ColinMiPerry) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/6/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix/dom-nesting-warnings` --- ### 📝 Commits (3) - [`7bdde40`](https://github.com/Mintplex-Labs/anything-llm/commit/7bdde40d5625fac4a608bd0a61afbc8c91a99b43) fixed DOM nesting warnings - [`c797707`](https://github.com/Mintplex-Labs/anything-llm/commit/c7977072d483ef1bc8c556db7752a88b64c31483) ran yarn lint - [`d2e081d`](https://github.com/Mintplex-Labs/anything-llm/commit/d2e081df18096652dc58dcdf8fc41ec948279345) linting ### 📊 Changes **4 files changed** (+25 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Sidebar/ActiveWorkspaces/index.jsx` (+17 -16) 📝 `frontend/src/pages/WorkspaceSettings/ChatSettings/ChatPromptSettings/index.jsx` (+4 -7) 📝 `frontend/src/pages/WorkspaceSettings/GeneralAppearance/SuggestedChatMessages/index.jsx` (+2 -2) 📝 `frontend/src/pages/WorkspaceSettings/VectorDatabase/VectorCount/index.jsx` (+2 -2) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #3772 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> In ActiveWorkspaces, the nested <Link> tag was replaced with a button tag with onClick behavior to handle navigation. Client-side routing performance is maintained. In SuggestedChatMessages, <p> tag was replaced with a <div> tag to prevent the div in p warning. ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:44 -05:00
yindo closed this issue 2026-02-22 18:35:45 -05:00
yindo changed title from [PR #3773] Fix/dom nesting warnings to [PR #3773] [MERGED] Fix/dom nesting warnings 2026-06-05 15:18:20 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?