Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-18 19:34:33 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #3893] [MERGED] fixed drupal connector #4450

New Issue
Closed
opened 2026-02-22 18:35:51 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:51 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/3893
Author: @rexjohannes
Created: 5/27/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @timothycarambat

Base: master ← Head: 3875-drupal-wiki-connector-fix

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 collector/utils/extensions/DrupalWiki/DrupalWiki/index.js (+1 -5)

📄 Description

https://github.com/Mintplex-Labs/anything-llm/issues/3875#issuecomment-2913211343

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #3875

What is in this change?

This pull request simplifies the handling of token count estimation in the DrupalWiki class by removing unnecessary conditional logic and directly computing the token count where it is used.

Code simplification:

  • Removed the tokenCount variable and its associated conditional logic for calculating token count, simplifying the code by directly calling tokenizeString(page.processedBody) in the token_count_estimate property. (collector/utils/extensions/DrupalWiki/DrupalWiki/index.js, [1] [2]

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/3893 **Author:** [@rexjohannes](https://github.com/rexjohannes) **Created:** 5/27/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `3875-drupal-wiki-connector-fix` --- ### 📝 Commits (1) - [`4e9861d`](https://github.com/Mintplex-Labs/anything-llm/commit/4e9861d3caf9702d9398ca839759d9deae328066) fixed drupal connector ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `collector/utils/extensions/DrupalWiki/DrupalWiki/index.js` (+1 -5) </details> ### 📄 Description https://github.com/Mintplex-Labs/anything-llm/issues/3875#issuecomment-2913211343 ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #3875 ### What is in this change? This pull request simplifies the handling of token count estimation in the `DrupalWiki` class by removing unnecessary conditional logic and directly computing the token count where it is used. Code simplification: * Removed the `tokenCount` variable and its associated conditional logic for calculating token count, simplifying the code by directly calling `tokenizeString(page.processedBody)` in the `token_count_estimate` property. (`collector/utils/extensions/DrupalWiki/DrupalWiki/index.js`, [[1]](diffhunk://#diff-8dcfecb31d5c2936f18c14744cd80413bde8f447e716c0ab5086ba32994a203fL183-L186) [[2]](diffhunk://#diff-8dcfecb31d5c2936f18c14744cd80413bde8f447e716c0ab5086ba32994a203fL198-R194) ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [ ] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:51 -05:00
yindo closed this issue 2026-02-22 18:35:51 -05:00
yindo changed title from [PR #3893] fixed drupal connector to [PR #3893] [MERGED] fixed drupal connector 2026-06-05 15:18:37 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?