Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #3954] [MERGED] remove LLM Instruction inputVariable requirement #4474

New Issue
Closed
opened 2026-02-22 18:35:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:35:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/3954
Author: @timothycarambat
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @timothycarambat

Base: master ← Head: llm-instruction-block-improvements

📝 Commits (1)

  • 62bee24 remove LLM Instruction inputVariable requirement

📊 Changes

4 files changed (+4 additions, -31 deletions)

View changed files

📝 frontend/src/pages/Admin/AgentBuilder/BlockList/index.jsx (+0 -1)
📝 frontend/src/pages/Admin/AgentBuilder/nodes/LLMInstructionNode/index.jsx (+0 -11)
📝 server/utils/agentFlows/executors/llm-instruction.js (+4 -15)
📝 server/utils/agentFlows/flowTypes.js (+0 -4)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

connect #3863

What is in this change?

  • With #3863 we have object response traversal for JSON objects (if available)
  • Since variable are already filled in globally per block, there is no reason to require inputVariable in this block since it has no impact on the rendered instruction - any variable can be used.

There is a world where multiple API calls are run and stored in various result vars that then come together at the instruction block in various ways. This makes a singular inputVariable redundant and confusing to users.

Additional Information

  • Existing blocks with inputVariables will be ignored, but because of the above nothing will change.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/3954 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `llm-instruction-block-improvements` --- ### 📝 Commits (1) - [`62bee24`](https://github.com/Mintplex-Labs/anything-llm/commit/62bee249243e4a0024109dd4c94bba47ec62e94a) remove LLM Instruction `inputVariable` requirement ### 📊 Changes **4 files changed** (+4 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/Admin/AgentBuilder/BlockList/index.jsx` (+0 -1) 📝 `frontend/src/pages/Admin/AgentBuilder/nodes/LLMInstructionNode/index.jsx` (+0 -11) 📝 `server/utils/agentFlows/executors/llm-instruction.js` (+4 -15) 📝 `server/utils/agentFlows/flowTypes.js` (+0 -4) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> connect #3863 ### What is in this change? - With #3863 we have object response traversal for JSON objects (if available) - Since variable are already filled in globally per block, there is no reason to require `inputVariable` in this block since it has no impact on the rendered instruction - any variable can be used. There is a world where multiple API calls are run and stored in various result vars that then come together at the instruction block in various ways. This makes a singular `inputVariable` redundant and confusing to users. <!-- Describe the changes in this PR that are impactful to the repo. --> ### Additional Information - Existing blocks with `inputVariables` will be ignored, but because of the above nothing will change. <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:35:54 -05:00
yindo closed this issue 2026-02-22 18:35:54 -05:00
yindo changed title from [PR #3954] remove LLM Instruction `inputVariable` requirement to [PR #3954] [MERGED] remove LLM Instruction `inputVariable` requirement 2026-06-05 15:18:44 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?