Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4150] [MERGED] SQL preflight connection validation #4536

New Issue
Closed
opened 2026-02-22 18:36:01 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:01 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4150
Author: @shatfield4
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @timothycarambat

Base: master ← Head: 4149-feat-sql-preflight-connections

📝 Commits (7)

  • 6b28ae8 wip sql connection string validation
  • 2a26b19 handle failed sql connections in frontend
  • 64e124a sql preflight connection validation on modal save
  • 2090df1 Merge branch '4149-feat-sql-preflight-connections' of github.com:Mintplex-Labs/anything-llm into 4149-feat-sql-preflight-connections
  • 3174fda revert unneeded be/fe changes
  • 7ffda9c Merge branch 'master' into 4149-feat-sql-preflight-connections
  • 6e6ede9 linting, form updates

📊 Changes

9 files changed (+185 additions, -36 deletions)

View changed files

📝 frontend/src/models/system.js (+19 -0)
📝 frontend/src/pages/Admin/Agents/SQLConnectorSelection/DBConnection.jsx (+2 -4)
📝 frontend/src/pages/Admin/Agents/SQLConnectorSelection/NewConnectionModal.jsx (+50 -13)
📝 frontend/src/pages/Admin/Agents/SQLConnectorSelection/index.jsx (+13 -10)
📝 server/endpoints/system.js (+36 -0)
📝 server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/MSSQL.js (+15 -3)
📝 server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/MySQL.js (+15 -3)
📝 server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/Postgresql.js (+15 -3)
📝 server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/index.js (+20 -0)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4149

What is in this change?

  • Adds preflight validation to SQL agent configurations
  • Validate connection string on NewConnectionModal save
  • Allows users to continue editing connection config on failed connection
  • Improves UX of SQL agent setup

Additional Information

Tested On:

  • MSSQL (including encryption)
  • PostgreSQL
  • MySQL

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4150 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `4149-feat-sql-preflight-connections` --- ### 📝 Commits (7) - [`6b28ae8`](https://github.com/Mintplex-Labs/anything-llm/commit/6b28ae8d30a5eb6db75e69db6dd2312b11370473) wip sql connection string validation - [`2a26b19`](https://github.com/Mintplex-Labs/anything-llm/commit/2a26b1976e6659582c2311cbc45cf7b4e191c327) handle failed sql connections in frontend - [`64e124a`](https://github.com/Mintplex-Labs/anything-llm/commit/64e124a7a56abc168902ba3b4f3993f5ac131059) sql preflight connection validation on modal save - [`2090df1`](https://github.com/Mintplex-Labs/anything-llm/commit/2090df10971b0d4ad5243553f0e6020ac8433901) Merge branch '4149-feat-sql-preflight-connections' of github.com:Mintplex-Labs/anything-llm into 4149-feat-sql-preflight-connections - [`3174fda`](https://github.com/Mintplex-Labs/anything-llm/commit/3174fdac9a7eb035d9dd6ce19e2b4e272a12c844) revert unneeded be/fe changes - [`7ffda9c`](https://github.com/Mintplex-Labs/anything-llm/commit/7ffda9cffbb1b7d50c196e825425f14444c742c5) Merge branch 'master' into 4149-feat-sql-preflight-connections - [`6e6ede9`](https://github.com/Mintplex-Labs/anything-llm/commit/6e6ede99fee58634ae288df3d6d6482ba1ae46ea) linting, form updates ### 📊 Changes **9 files changed** (+185 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/models/system.js` (+19 -0) 📝 `frontend/src/pages/Admin/Agents/SQLConnectorSelection/DBConnection.jsx` (+2 -4) 📝 `frontend/src/pages/Admin/Agents/SQLConnectorSelection/NewConnectionModal.jsx` (+50 -13) 📝 `frontend/src/pages/Admin/Agents/SQLConnectorSelection/index.jsx` (+13 -10) 📝 `server/endpoints/system.js` (+36 -0) 📝 `server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/MSSQL.js` (+15 -3) 📝 `server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/MySQL.js` (+15 -3) 📝 `server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/Postgresql.js` (+15 -3) 📝 `server/utils/agents/aibitat/plugins/sql-agent/SQLConnectors/index.js` (+20 -0) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [ ] 🐛 fix - [x] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #4149 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Adds preflight validation to SQL agent configurations - Validate connection string on `NewConnectionModal` save - Allows users to continue editing connection config on failed connection - Improves UX of SQL agent setup ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> Tested On: - [x] MSSQL (including encryption) - [x] PostgreSQL - [x] MySQL ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:01 -05:00
yindo closed this issue 2026-02-22 18:36:02 -05:00
yindo changed title from [PR #4150] SQL preflight connection validation to [PR #4150] [MERGED] SQL preflight connection validation 2026-06-05 15:19:04 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?