Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4545] [MERGED] fix(server): correct Qdrant batching logic for large uploads #4668

New Issue
Closed
opened 2026-02-22 18:36:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:18 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4545
Author: @aeromech-1
Created: 10/15/2025
Status: ✅ Merged
Merged: 10/15/2025
Merged by: @timothycarambat

Base: master ← Head: fix/qdrant-batching

📝 Commits (3)

  • ed452ed fix(server): correct Qdrant batching logic for large uploads
  • bd2a923 modify O(3N) process to O(N)
  • 0772c22 Merge branch 'master' into fix/qdrant-batching

📊 Changes

1 file changed (+0 additions, -0 deletions)

View changed files

📝 server/utils/vectorDbProviders/qdrant/index.js (+22 -12)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4544

What is in this change?

This change corrects the batching logic in the Qdrant vector provider (index.js).

Previously, the code would attempt to upsert all generated vector chunks in a single request. This caused an error when the number of chunks exceeded Qdrant's batch limit (e.g., >500).

The fix ensures the code properly iterates through the pre-defined chunks and sends them in smaller, valid batches, allowing for the successful embedding of documents with a large number of chunks.

Additional Information

This issue was discovered when a less aggressive chunking strategy was used on a document, increasing the chunk count from ~200 to ~2000, which triggered the bug.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4545 **Author:** [@aeromech-1](https://github.com/aeromech-1) **Created:** 10/15/2025 **Status:** ✅ Merged **Merged:** 10/15/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix/qdrant-batching` --- ### 📝 Commits (3) - [`ed452ed`](https://github.com/Mintplex-Labs/anything-llm/commit/ed452edbb06cf8350c6d1092fcaeefbf6e1238bb) fix(server): correct Qdrant batching logic for large uploads - [`bd2a923`](https://github.com/Mintplex-Labs/anything-llm/commit/bd2a9231ea0276efda270c758d80c773f36f8fb3) modify O(3N) process to O(N) - [`0772c22`](https://github.com/Mintplex-Labs/anything-llm/commit/0772c22938597a26878e060b2f6e0b0e2bb75954) Merge branch 'master' into fix/qdrant-batching ### 📊 Changes **1 file changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/vectorDbProviders/qdrant/index.js` (+22 -12) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #4544 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> This change corrects the batching logic in the Qdrant vector provider (index.js). Previously, the code would attempt to upsert all generated vector chunks in a single request. This caused an error when the number of chunks exceeded Qdrant's batch limit (e.g., >500). The fix ensures the code properly iterates through the pre-defined chunks and sends them in smaller, valid batches, allowing for the successful embedding of documents with a large number of chunks. ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> This issue was discovered when a less aggressive chunking strategy was used on a document, increasing the chunk count from ~200 to ~2000, which triggered the bug. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:18 -05:00
yindo closed this issue 2026-02-22 18:36:18 -05:00
yindo changed title from [PR #4545] fix(server): correct Qdrant batching logic for large uploads to [PR #4545] [MERGED] fix(server): correct Qdrant batching logic for large uploads 2026-06-05 15:19:43 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4668
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?