Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4685] [MERGED] fixed empty scroll track in citations dropdown #4715

New Issue
Closed
opened 2026-02-22 18:36:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4685
Author: @17ColinMiPerry
Created: 11/25/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @timothycarambat

Base: master ← Head: fix/citation-horizontal-scroll

📝 Commits (4)

  • e51f2e5 fixed empty scroll track
  • f8c9d2c use overflow-x-none instead of overflow-x-auto for citation list
  • a60bc68 keep behaviour of x scroll, but hide scrollbar since it can be overflowing for no reason
  • 027789d Merge branch 'master' into fix/citation-horizontal-scroll

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/Citation/index.jsx (+1 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

The citation dropdown (On Windows, Google Chrome build 142.0.7444.176) included an empty horizontal scroll track due to the overflow-x-scroll style in the citations div.

Before

before

What is in this change?

overflow-x-scroll was changed to overflow-x-none to prevent the unnecessary empty scroll track.

After

after

Additional Information

On Windows, I believe overflow-x-scroll always makes the scrollbar track visible, even if it is empty. Unless the scroll track is being used to prevent layout shifting, I think overflow-x-none or overflow-x-auto should always be used to ensure parity in cross platform presentation. Due to the truncation of file names in the Citation component, there should never be overflow on cited file names with normal window sizes.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4685 **Author:** [@17ColinMiPerry](https://github.com/17ColinMiPerry) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix/citation-horizontal-scroll` --- ### 📝 Commits (4) - [`e51f2e5`](https://github.com/Mintplex-Labs/anything-llm/commit/e51f2e5983bcadc390c96a6916cda969fc77c3b5) fixed empty scroll track - [`f8c9d2c`](https://github.com/Mintplex-Labs/anything-llm/commit/f8c9d2c1138e37f768811fb3a6ada727065188e5) use overflow-x-none instead of overflow-x-auto for citation list - [`a60bc68`](https://github.com/Mintplex-Labs/anything-llm/commit/a60bc687862e8d5ea4ad021108ec68fca962b63a) keep behaviour of x scroll, but hide scrollbar since it can be overflowing for no reason - [`027789d`](https://github.com/Mintplex-Labs/anything-llm/commit/027789d0dbc675b723648f266b65ce2e43e0d435) Merge branch 'master' into fix/citation-horizontal-scroll ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/Citation/index.jsx` (+1 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues The citation dropdown (On Windows, Google Chrome build 142.0.7444.176) included an empty horizontal scroll track due to the overflow-x-scroll style in the citations div. ### Before <img width="1272" height="287" alt="before" src="https://github.com/user-attachments/assets/5ac0793e-2461-41aa-a571-e0a6246fba93" /> ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> overflow-x-scroll was changed to overflow-x-none to prevent the unnecessary empty scroll track. ### After <img width="1256" height="265" alt="after" src="https://github.com/user-attachments/assets/113ceffb-3af1-4621-b200-bbb444a0502f" /> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> On Windows, I believe overflow-x-scroll *always* makes the scrollbar track visible, even if it is empty. Unless the scroll track is being used to prevent layout shifting, I think overflow-x-none or overflow-x-auto should always be used to ensure parity in cross platform presentation. Due to the truncation of file names in the Citation component, there should never be overflow on cited file names with normal window sizes. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:23 -05:00
yindo closed this issue 2026-02-22 18:36:23 -05:00
yindo changed title from [PR #4685] fixed empty scroll track in citations dropdown to [PR #4685] [MERGED] fixed empty scroll track in citations dropdown 2026-06-05 15:19:59 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?