Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4847] [MERGED] Make XLSX spreadsheets visible in chat by combining sheets #4787

New Issue
Closed
opened 2026-02-22 18:36:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4847
Author: @shatfield4
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @timothycarambat

Base: master ← Head: 4840-bug-excel-spreadsheet-not-visible

📝 Commits (10+)

  • 644fa55 fix bug with xlsx files not being added as context
  • 1bbdaad lint
  • 3cf868e fix console logs/warn/error
  • 9248edb abstract sheet processing to function + normalize error handling
  • 3b284c9 Merge branch 'master' into 4840-bug-excel-spreadsheet-not-visible
  • 34d52c4 fix jsdoc
  • 67f97db patch xlsx filename to prevent orphaned doc
  • 5af732f reduce tokens
  • 469d6f0 correct pluralization
  • 23168d3 Merge branch 'master' into 4840-bug-excel-spreadsheet-not-visible

📊 Changes

1 file changed (+98 additions, -22 deletions)

View changed files

📝 collector/processSingleFile/convert/asXlsx.js (+98 -22)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4840

What is in this change?

  • Fixes a bug where uploading an XLSX file directly to chat would not append the file as context to the chat
  • Modified the asXlsx file converter util to append all sheets into a single file so that it can be injected directly into the context window when in parseOnly mode

Additional Information

  • Attempted to modify the getContextFiles util to accept folders but modifying the asXlsx converter was much a much simpler solution
  • asXlsx converter is the only converter that has this problem
  • cleanup-orphan-documents bg process works with the new fix

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4847 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `4840-bug-excel-spreadsheet-not-visible` --- ### 📝 Commits (10+) - [`644fa55`](https://github.com/Mintplex-Labs/anything-llm/commit/644fa55b5d9b9751a9936909ac2c50d6a131b325) fix bug with xlsx files not being added as context - [`1bbdaad`](https://github.com/Mintplex-Labs/anything-llm/commit/1bbdaad41b13937310413d1e36f5fb94a234f3ae) lint - [`3cf868e`](https://github.com/Mintplex-Labs/anything-llm/commit/3cf868e17fa097e5f1a322abaacb48484f44abba) fix console logs/warn/error - [`9248edb`](https://github.com/Mintplex-Labs/anything-llm/commit/9248edbd3f925c44138fc1da7313e8431fd0948e) abstract sheet processing to function + normalize error handling - [`3b284c9`](https://github.com/Mintplex-Labs/anything-llm/commit/3b284c9f01ab240c246c6994c9d947ba8d8e9d0f) Merge branch 'master' into 4840-bug-excel-spreadsheet-not-visible - [`34d52c4`](https://github.com/Mintplex-Labs/anything-llm/commit/34d52c4ce48d6cf2cfd9a88ee4d25b6752d85650) fix jsdoc - [`67f97db`](https://github.com/Mintplex-Labs/anything-llm/commit/67f97db1133fed8c8d86e11249292533d0be29db) patch xlsx filename to prevent orphaned doc - [`5af732f`](https://github.com/Mintplex-Labs/anything-llm/commit/5af732f269640456668928e96c311f1b91bbe272) reduce tokens - [`469d6f0`](https://github.com/Mintplex-Labs/anything-llm/commit/469d6f011245c861c3f4b704f328cddbf9a232ad) correct pluralization - [`23168d3`](https://github.com/Mintplex-Labs/anything-llm/commit/23168d3be1dc3b32eeaee94e850f966ad1453627) Merge branch 'master' into 4840-bug-excel-spreadsheet-not-visible ### 📊 Changes **1 file changed** (+98 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `collector/processSingleFile/convert/asXlsx.js` (+98 -22) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #4840 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Fixes a bug where uploading an XLSX file directly to chat would not append the file as context to the chat - Modified the `asXlsx` file converter util to append all sheets into a single file so that it can be injected directly into the context window when in `parseOnly` mode ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> - Attempted to modify the `getContextFiles` util to accept folders but modifying the asXlsx converter was much a much simpler solution - `asXlsx` converter is the only converter that has this problem - `cleanup-orphan-documents` bg process works with the new fix ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:32 -05:00
yindo closed this issue 2026-02-22 18:36:32 -05:00
yindo changed title from [PR #4847] Make XLSX spreadsheets visible in chat by combining sheets to [PR #4847] [MERGED] Make XLSX spreadsheets visible in chat by combining sheets 2026-06-05 15:20:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?