Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4928] [MERGED] fix: add rel=noreferrer to target=_blank links #4827

New Issue
Closed
opened 2026-02-22 18:36:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:36 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4928
Author: @angelplusultra
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @timothycarambat

Base: 4917-enable-essential-rules-and-apply-fixes-in-frontend-eslint ← Head: 4917-fix-no-target-blank

📝 Commits (1)

  • 5852eca Fix no target blank errors

📊 Changes

4 files changed (+5 additions, -0 deletions)

View changed files

📝 frontend/src/pages/Admin/Agents/AgentFlows/index.jsx (+1 -0)
📝 frontend/src/pages/Admin/Agents/Imported/SkillList/index.jsx (+1 -0)
📝 frontend/src/pages/Admin/ExperimentalFeatures/Features/LiveSync/toggle.jsx (+1 -0)
📝 frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx (+2 -0)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

Base PR: #4923

What is in this change?

This PR fixes ESLint react/jsx-no-target-blank violations by adding rel="noreferrer" to external links that use target="_blank":

  • src/pages/Admin/Agents/AgentFlows/index.jsx - Agent Flows documentation link
  • src/pages/Admin/Agents/Imported/SkillList/index.jsx - Agent Docs link
  • src/pages/Admin/ExperimentalFeatures/Features/LiveSync/toggle.jsx - Feature documentation link
  • src/pages/GeneralSettings/PrivacyAndData/index.jsx - GitHub and email links

This prevents a potential security vulnerability where the new page could access window.opener.

Additional Information

These changes are part of the frontend ESLint cleanup effort to enable stricter linting rules.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4928 **Author:** [@angelplusultra](https://github.com/angelplusultra) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `4917-enable-essential-rules-and-apply-fixes-in-frontend-eslint` ← **Head:** `4917-fix-no-target-blank` --- ### 📝 Commits (1) - [`5852eca`](https://github.com/Mintplex-Labs/anything-llm/commit/5852eca20c0ccc74c50cba41db6a56c6f3951e17) Fix no target blank errors ### 📊 Changes **4 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/Admin/Agents/AgentFlows/index.jsx` (+1 -0) 📝 `frontend/src/pages/Admin/Agents/Imported/SkillList/index.jsx` (+1 -0) 📝 `frontend/src/pages/Admin/ExperimentalFeatures/Features/LiveSync/toggle.jsx` (+1 -0) 📝 `frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx` (+2 -0) </details> ### 📄 Description ### Pull Request Type - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues Base PR: #4923 ### What is in this change? This PR fixes ESLint `react/jsx-no-target-blank` violations by adding `rel="noreferrer"` to external links that use `target="_blank"`: - `src/pages/Admin/Agents/AgentFlows/index.jsx` - Agent Flows documentation link - `src/pages/Admin/Agents/Imported/SkillList/index.jsx` - Agent Docs link - `src/pages/Admin/ExperimentalFeatures/Features/LiveSync/toggle.jsx` - Feature documentation link - `src/pages/GeneralSettings/PrivacyAndData/index.jsx` - GitHub and email links This prevents a potential security vulnerability where the new page could access `window.opener`. ### Additional Information These changes are part of the frontend ESLint cleanup effort to enable stricter linting rules. ### Developer Validations - [x] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:36 -05:00
yindo closed this issue 2026-02-22 18:36:37 -05:00
yindo changed title from [PR #4928] fix: add rel=noreferrer to target=_blank links to [PR #4928] [MERGED] fix: add rel=noreferrer to target=_blank links 2026-06-05 15:20:35 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?