Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4970] [MERGED] Fix Sidebar Clipping When Closed #4846

New Issue
Closed
opened 2026-02-22 18:36:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:39 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4970
Author: @angelplusultra
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @timothycarambat

Base: master ← Head: 4969-bug-thread-sidebar-clipping-through-chat-container

📝 Commits (1)

  • ee2452d fix sidebar clipping when closed

📊 Changes

2 files changed (+33 additions, -31 deletions)

View changed files

📝 frontend/src/components/Sidebar/SidebarToggle/index.jsx (+1 -1)
📝 frontend/src/components/Sidebar/index.jsx (+32 -30)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4969

What is in this change?

Before

https://github.com/user-attachments/assets/5f225906-dd7e-4c50-b731-cd577582160b

After

https://github.com/user-attachments/assets/a5cfb43c-0e39-48eb-b885-0387080fdd46

Sidebar (index.jsx):

  • Added relative to the outer sidebar wrapper to serve as the positioning anchor for the toggle button
  • Wrapped the logo area and sidebar panel in a new overflow-hidden h-full inner div — this clips the sidebar content (including the
    absolutely-positioned footer) when the sidebar collapses to width: 0
  • Moved the ToggleSidebarButton outside the overflow container so it's never clipped during open/close transitions
  • Removed justify-between from the logo row since the toggle button is no longer a child of it

SidebarToggle (SidebarToggle/index.jsx):

  • Toggle button is now always absolute positioned (previously only absolute when sidebar was closed)
  • Transitions smoothly between left-[248px] (open) and left-[30px] (closed) using transition-all

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4970 **Author:** [@angelplusultra](https://github.com/angelplusultra) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `4969-bug-thread-sidebar-clipping-through-chat-container` --- ### 📝 Commits (1) - [`ee2452d`](https://github.com/Mintplex-Labs/anything-llm/commit/ee2452ddb94633ccc9ecb58431e73ac4f138831f) fix sidebar clipping when closed ### 📊 Changes **2 files changed** (+33 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Sidebar/SidebarToggle/index.jsx` (+1 -1) 📝 `frontend/src/components/Sidebar/index.jsx` (+32 -30) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #4969 ### What is in this change? ### Before https://github.com/user-attachments/assets/5f225906-dd7e-4c50-b731-cd577582160b ### After https://github.com/user-attachments/assets/a5cfb43c-0e39-48eb-b885-0387080fdd46 <!-- Describe the changes in this PR that are impactful to the repo. --> Sidebar (index.jsx): - Added relative to the outer sidebar wrapper to serve as the positioning anchor for the toggle button - Wrapped the logo area and sidebar panel in a new overflow-hidden h-full inner div — this clips the sidebar content (including the absolutely-positioned footer) when the sidebar collapses to width: 0 - Moved the ToggleSidebarButton outside the overflow container so it's never clipped during open/close transitions - Removed justify-between from the logo row since the toggle button is no longer a child of it SidebarToggle (SidebarToggle/index.jsx): - Toggle button is now always absolute positioned (previously only absolute when sidebar was closed) - Transitions smoothly between left-[248px] (open) and left-[30px] (closed) using transition-all ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:39 -05:00
yindo closed this issue 2026-02-22 18:36:39 -05:00
yindo changed title from [PR #4970] Fix Sidebar Clipping When Closed to [PR #4970] [MERGED] Fix Sidebar Clipping When Closed 2026-06-05 15:20:41 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4846
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?