Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5146] [MERGED] refactor: refactor agent skills settings page to use i18n translation keys #5324

New Issue
Closed
opened 2026-06-05 15:20:58 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:20:58 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5146
Author: @angelplusultra
Created: 3/4/2026
Status: ✅ Merged
Merged: 3/5/2026
Merged by: @timothycarambat

Base: master ← Head: 5142-refactor-wire-up-agent-skills-ui-to-use-i18n-translation-keys

📝 Commits (7)

  • fea83f5 refactor agent skills to read from translation keys instead of hardcoded strings
  • 3153d50 add missing sql agent description key
  • 45d92f1 Remove fallbacks
  • 9a44abc adjust translation
  • fdd1c6c swap to factor pattern
  • 376c881 normalize translations (#5147)
  • d5a3d05 Merge branch 'master' into 5142-refactor-wire-up-agent-skills-ui-to-use-i18n-translation-keys

📊 Changes

28 files changed (+242 additions, -120 deletions)

View changed files

📝 frontend/src/locales/ar/common.js (+9 -4)
📝 frontend/src/locales/cs/common.js (+9 -4)
📝 frontend/src/locales/da/common.js (+9 -4)
📝 frontend/src/locales/de/common.js (+9 -4)
📝 frontend/src/locales/en/common.js (+9 -4)
📝 frontend/src/locales/es/common.js (+9 -4)
📝 frontend/src/locales/et/common.js (+9 -3)
📝 frontend/src/locales/fa/common.js (+9 -4)
📝 frontend/src/locales/fr/common.js (+9 -4)
📝 frontend/src/locales/he/common.js (+9 -4)
📝 frontend/src/locales/it/common.js (+9 -4)
📝 frontend/src/locales/ja/common.js (+9 -4)
📝 frontend/src/locales/ko/common.js (+9 -4)
📝 frontend/src/locales/lv/common.js (+9 -4)
📝 frontend/src/locales/nl/common.js (+9 -4)
📝 frontend/src/locales/pl/common.js (+9 -4)
📝 frontend/src/locales/pt_BR/common.js (+9 -4)
📝 frontend/src/locales/ro/common.js (+9 -4)
📝 frontend/src/locales/ru/common.js (+9 -4)
📝 frontend/src/locales/tr/common.js (+9 -4)

...and 8 more files

📄 Description

Pull Request Type

  • ✨ feat (New feature)
  • 🐛 fix (Bug fix)
  • ♻️ refactor (Code refactoring without changing behavior)
  • 💄 style (UI style changes)
  • 🔨 chore (Build, CI, maintenance)
  • 📝 docs (Documentation updates)

Relevant Issues

resolves #5142

Description

Refactors the agent skills page (/settings/agents) to read titles and descriptions from i18n translation keys instead of hardcoded English strings.

  • skills.js — Replaced hardcoded title/description with titleKey/descriptionKey pointing to agent.skill.* translation keys
  • DefaultSkillPanel, GenericSkillPanel — Resolve titleKey/descriptionKey via useTranslation() hook
  • AgentWebSearchSelection, AgentSQLConnectorSelection — Accept titleKey/descriptionKey props and resolve via t(), with hardcoded fallbacks
  • SkillList — Resolves titleKey via t() for the sidebar skill list
  • en/common.js — Added agent.skill.sql (title + description), consolidated agent.skill.web.desc-start/desc-end into a single agent.skill.web.description, fixed agent.skill.web.title to match the original UI text

All translation values match the previously hardcoded UI strings exactly.

Visuals (if applicable)

No visual changes — UI text remains identical, now sourced from translation files.

Additional Information

Normalized translations in #5147

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated (if applicable)
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5146 **Author:** [@angelplusultra](https://github.com/angelplusultra) **Created:** 3/4/2026 **Status:** ✅ Merged **Merged:** 3/5/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `5142-refactor-wire-up-agent-skills-ui-to-use-i18n-translation-keys` --- ### 📝 Commits (7) - [`fea83f5`](https://github.com/Mintplex-Labs/anything-llm/commit/fea83f548dddf4c1ed36cfbe260af0e22bb80e66) refactor agent skills to read from translation keys instead of hardcoded strings - [`3153d50`](https://github.com/Mintplex-Labs/anything-llm/commit/3153d50b444db6b3a126b981e3e29befd2f01406) add missing sql agent description key - [`45d92f1`](https://github.com/Mintplex-Labs/anything-llm/commit/45d92f119758d1e50939a3f04e7fd086b300e090) Remove fallbacks - [`9a44abc`](https://github.com/Mintplex-Labs/anything-llm/commit/9a44abc4e96b2c82158d4af51dbcd22dcaa5d148) adjust translation - [`fdd1c6c`](https://github.com/Mintplex-Labs/anything-llm/commit/fdd1c6cc75d3acc9be777b760b0e97b5b66e3d6f) swap to factor pattern - [`376c881`](https://github.com/Mintplex-Labs/anything-llm/commit/376c88163ddee1469b69e1e14f421bcd3d48766f) normalize translations (#5147) - [`d5a3d05`](https://github.com/Mintplex-Labs/anything-llm/commit/d5a3d0573570b9a52b32db068838d49fe86b0ab0) Merge branch 'master' into 5142-refactor-wire-up-agent-skills-ui-to-use-i18n-translation-keys ### 📊 Changes **28 files changed** (+242 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/locales/ar/common.js` (+9 -4) 📝 `frontend/src/locales/cs/common.js` (+9 -4) 📝 `frontend/src/locales/da/common.js` (+9 -4) 📝 `frontend/src/locales/de/common.js` (+9 -4) 📝 `frontend/src/locales/en/common.js` (+9 -4) 📝 `frontend/src/locales/es/common.js` (+9 -4) 📝 `frontend/src/locales/et/common.js` (+9 -3) 📝 `frontend/src/locales/fa/common.js` (+9 -4) 📝 `frontend/src/locales/fr/common.js` (+9 -4) 📝 `frontend/src/locales/he/common.js` (+9 -4) 📝 `frontend/src/locales/it/common.js` (+9 -4) 📝 `frontend/src/locales/ja/common.js` (+9 -4) 📝 `frontend/src/locales/ko/common.js` (+9 -4) 📝 `frontend/src/locales/lv/common.js` (+9 -4) 📝 `frontend/src/locales/nl/common.js` (+9 -4) 📝 `frontend/src/locales/pl/common.js` (+9 -4) 📝 `frontend/src/locales/pt_BR/common.js` (+9 -4) 📝 `frontend/src/locales/ro/common.js` (+9 -4) 📝 `frontend/src/locales/ru/common.js` (+9 -4) 📝 `frontend/src/locales/tr/common.js` (+9 -4) _...and 8 more files_ </details> ### 📄 Description ### Pull Request Type - [ ] ✨ feat (New feature) - [ ] 🐛 fix (Bug fix) - [x] ♻️ refactor (Code refactoring without changing behavior) - [ ] 💄 style (UI style changes) - [ ] 🔨 chore (Build, CI, maintenance) - [ ] 📝 docs (Documentation updates) ### Relevant Issues resolves #5142 ### Description Refactors the agent skills page (`/settings/agents`) to read titles and descriptions from i18n translation keys instead of hardcoded English strings. - **`skills.js`** — Replaced hardcoded `title`/`description` with `titleKey`/`descriptionKey` pointing to `agent.skill.*` translation keys - **`DefaultSkillPanel`**, **`GenericSkillPanel`** — Resolve `titleKey`/`descriptionKey` via `useTranslation()` hook - **`AgentWebSearchSelection`**, **`AgentSQLConnectorSelection`** — Accept `titleKey`/`descriptionKey` props and resolve via `t()`, with hardcoded fallbacks - **`SkillList`** — Resolves `titleKey` via `t()` for the sidebar skill list - **`en/common.js`** — Added `agent.skill.sql` (title + description), consolidated `agent.skill.web.desc-start`/`desc-end` into a single `agent.skill.web.description`, fixed `agent.skill.web.title` to match the original UI text All translation values match the previously hardcoded UI strings exactly. ### Visuals (if applicable) No visual changes — UI text remains identical, now sourced from translation files. ### Additional Information Normalized translations in #5147 ### Developer Validations - [x] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated (if applicable) - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:20:58 -04:00
yindo closed this issue 2026-06-05 15:20:58 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?