Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5261] [MERGED] add ask to run prompt for tool calls (demo) #5377

New Issue
Closed
opened 2026-06-05 15:21:10 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:10 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5261
Author: @timothycarambat
Created: 3/24/2026
Status: ✅ Merged
Merged: 3/24/2026
Merged by: @timothycarambat

Base: master ← Head: tool-call-ask-to-run

📝 Commits (7)

📊 Changes

44 files changed (+1154 additions, -8 deletions)

View changed files

➕ frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/ToolApprovalRequest/index.jsx (+243 -0)
📝 frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/index.jsx (+21 -0)
📝 frontend/src/components/WorkspaceChat/ChatContainer/index.jsx (+1 -0)
📝 frontend/src/locales/ar/common.js (+8 -0)
📝 frontend/src/locales/cs/common.js (+8 -0)
📝 frontend/src/locales/da/common.js (+9 -0)
📝 frontend/src/locales/de/common.js (+9 -0)
📝 frontend/src/locales/en/common.js (+8 -0)
📝 frontend/src/locales/es/common.js (+8 -0)
📝 frontend/src/locales/et/common.js (+8 -0)
📝 frontend/src/locales/fa/common.js (+8 -0)
📝 frontend/src/locales/fr/common.js (+9 -0)
📝 frontend/src/locales/he/common.js (+8 -0)
📝 frontend/src/locales/it/common.js (+10 -0)
📝 frontend/src/locales/ja/common.js (+8 -0)
📝 frontend/src/locales/ko/common.js (+8 -0)
📝 frontend/src/locales/lt/common.js (+8 -0)
📝 frontend/src/locales/lv/common.js (+9 -0)
📝 frontend/src/locales/nl/common.js (+10 -0)
📝 frontend/src/locales/pl/common.js (+9 -0)

...and 24 more files

📄 Description

Pull Request Type

  • ✨ feat (New feature)
  • 🐛 fix (Bug fix)
  • ♻️ refactor (Code refactoring without changing behavior)
  • 💄 style (UI style changes)
  • 🔨 chore (Build, CI, maintenance)
  • 📝 docs (Documentation updates)

Description

  • Adds much needed "Ask to run" loop for tool calling. Must be implemented manually right now on specific high-level tool calls.
  • Implements both non-user and user level whitelisting for skill calling
  • For demo purpose: web-scraping is using this loop. This will not be used in any skills at merge-time
  • Extended functionality to support Telegram messages as well for permissioned tool calls (cannot whitelist though).

Visuals (if applicable)


Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated (if applicable)
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5261 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 3/24/2026 **Status:** ✅ Merged **Merged:** 3/24/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `tool-call-ask-to-run` --- ### 📝 Commits (7) - [`c0344f0`](https://github.com/Mintplex-Labs/anything-llm/commit/c0344f0bfb4973d9cc64b700645b0896fae99b7a) add ask to run prompt for tools - [`9861319`](https://github.com/Mintplex-Labs/anything-llm/commit/9861319492f7f207e3ad1701ca04bec38be8bd0f) border-none on buttons - [`8922488`](https://github.com/Mintplex-Labs/anything-llm/commit/8922488aa5d758eb4ca807f98916a88bd2aa93c4) translations - [`96e4190`](https://github.com/Mintplex-Labs/anything-llm/commit/96e4190215d267ed0460d7aca1279b47a0bde1a9) linting - [`51fc507`](https://github.com/Mintplex-Labs/anything-llm/commit/51fc50747823c3e470aa2a45567c28fa530737f4) i18n (#5263) - [`340c5e9`](https://github.com/Mintplex-Labs/anything-llm/commit/340c5e997a43cb0e3d45665e59973c790f2eac94) extend approve/deny requests to telegram - [`af04dd3`](https://github.com/Mintplex-Labs/anything-llm/commit/af04dd3b5a382a9d9ee8a05642f572bd3f0046cb) break up handler ### 📊 Changes **44 files changed** (+1154 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/ToolApprovalRequest/index.jsx` (+243 -0) 📝 `frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/index.jsx` (+21 -0) 📝 `frontend/src/components/WorkspaceChat/ChatContainer/index.jsx` (+1 -0) 📝 `frontend/src/locales/ar/common.js` (+8 -0) 📝 `frontend/src/locales/cs/common.js` (+8 -0) 📝 `frontend/src/locales/da/common.js` (+9 -0) 📝 `frontend/src/locales/de/common.js` (+9 -0) 📝 `frontend/src/locales/en/common.js` (+8 -0) 📝 `frontend/src/locales/es/common.js` (+8 -0) 📝 `frontend/src/locales/et/common.js` (+8 -0) 📝 `frontend/src/locales/fa/common.js` (+8 -0) 📝 `frontend/src/locales/fr/common.js` (+9 -0) 📝 `frontend/src/locales/he/common.js` (+8 -0) 📝 `frontend/src/locales/it/common.js` (+10 -0) 📝 `frontend/src/locales/ja/common.js` (+8 -0) 📝 `frontend/src/locales/ko/common.js` (+8 -0) 📝 `frontend/src/locales/lt/common.js` (+8 -0) 📝 `frontend/src/locales/lv/common.js` (+9 -0) 📝 `frontend/src/locales/nl/common.js` (+10 -0) 📝 `frontend/src/locales/pl/common.js` (+9 -0) _...and 24 more files_ </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ✨ feat (New feature) - [ ] 🐛 fix (Bug fix) - [x] ♻️ refactor (Code refactoring without changing behavior) - [x] 💄 style (UI style changes) - [ ] 🔨 chore (Build, CI, maintenance) - [ ] 📝 docs (Documentation updates) ### Description - Adds much needed "Ask to run" loop for tool calling. Must be implemented manually right now on specific high-level tool calls. - Implements both non-user and user level whitelisting for skill calling - ~For demo purpose: web-scraping is using this loop. This will not be used in any skills at merge-time~ - Extended functionality to support Telegram messages as well for permissioned tool calls (cannot whitelist though). <!-- Describe the changes in this PR that are impactful to the repo. What problem does it solve? --> ### Visuals (if applicable) <video src="https://github.com/user-attachments/assets/e4a044b5-f181-4def-9a90-32a3ae1b2e2c"></video> <video src="https://github.com/user-attachments/assets/ae9ffa92-1ea7-4b6e-bab0-a91be682e6ea"></video> <!-- Add screenshots or screen recordings to demonstrate the changes, especially for UI updates. --> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [ ] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated (if applicable) - [ ] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:10 -04:00
yindo closed this issue 2026-06-05 15:21:10 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?