Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5310] [CLOSED] fix: coerce env values to string before .includes() check in updateENV #5402

New Issue
Closed
opened 2026-06-05 15:21:14 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:14 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5310
Author: @xandr0s
Created: 3/31/2026
Status: ❌ Closed

Base: master ← Head: fix/update-env-type-coercion

📝 Commits (1)

  • 1406659 fix: coerce env values to string before .includes() check in updateENV

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/utils/helpers/updateENV.js (+1 -1)

📄 Description

Summary

  • Fix crash (500) in POST /api/v1/system/update-env when numeric values are passed
  • Root cause: .includes("******") called on Number type — Number has no .includes() method
  • Fix: wrap with String() before calling .includes()

Steps to reproduce

curl -X POST /api/v1/system/update-env   -d '{"GenericOpenAiEmbeddingMaxConcurrentChunks": 1}'
# => 500 Internal Server Error
# => TypeError: newENVs[key].includes is not a function

Change

- (key) => validKeys.includes(key) && !newENVs[key].includes("******")
+ (key) => validKeys.includes(key) && !String(newENVs[key]).includes("******")

Test plan

  • POST numeric value to /api/v1/system/update-env — no crash, value saved
  • POST string with ****** — still filtered correctly
  • POST normal string — saved as before

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5310 **Author:** [@xandr0s](https://github.com/xandr0s) **Created:** 3/31/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/update-env-type-coercion` --- ### 📝 Commits (1) - [`1406659`](https://github.com/Mintplex-Labs/anything-llm/commit/1406659f5f8b88ebb3962ad784d1df5ea5ea403f) fix: coerce env values to string before .includes() check in updateENV ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/helpers/updateENV.js` (+1 -1) </details> ### 📄 Description ## Summary - Fix crash (500) in `POST /api/v1/system/update-env` when numeric values are passed - Root cause: `.includes("******")` called on Number type — Number has no `.includes()` method - Fix: wrap with `String()` before calling `.includes()` ## Steps to reproduce ```bash curl -X POST /api/v1/system/update-env -d '{"GenericOpenAiEmbeddingMaxConcurrentChunks": 1}' # => 500 Internal Server Error # => TypeError: newENVs[key].includes is not a function ``` ## Change ```diff - (key) => validKeys.includes(key) && !newENVs[key].includes("******") + (key) => validKeys.includes(key) && !String(newENVs[key]).includes("******") ``` ## Test plan - [ ] POST numeric value to `/api/v1/system/update-env` — no crash, value saved - [ ] POST string with `******` — still filtered correctly - [ ] POST normal string — saved as before --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:14 -04:00
yindo closed this issue 2026-06-05 15:21:15 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?