Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5325] [MERGED] fix(lemonade): throw on embedding failures instead of returning empty #5407

New Issue
Closed
opened 2026-06-05 15:21:16 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:16 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5325
Author: @nehaaprasad
Created: 4/2/2026
Status: ✅ Merged
Merged: 4/2/2026
Merged by: @timothycarambat

Base: master ← Head: fix/lem-emb-err-rep

📝 Commits (3)

  • a0f32db fix(lemonade): throw on embedding failures instead of returning empty vectors
  • 0b6f6f7 use class logger
  • 55bfc50 Merge branch 'master' into fix/lem-emb-err-rep

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 server/utils/EmbeddingEngines/lemonade/index.js (+4 -4)

📄 Description

[x] 🐛 fix (Bug fix)

Relevant Issues

resolves #5305

Description

  • Fix Lemonade embedder to throw on embedding failures instead of returning empty vectors.
  • Prevents documents from being falsely marked as successfully embedded when Lemonade errors occur.

Visuals (if applicable)

  • N/A

Additional Information

  • Aligns Lemonade error handling with other embedding engines.

Developer Validations

[ ] I ran yarn lint from the root of the repo & committed changes
[ ] Relevant documentation has been updated (if applicable)
[ ] I have tested my code functionality
[ ] Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5325 **Author:** [@nehaaprasad](https://github.com/nehaaprasad) **Created:** 4/2/2026 **Status:** ✅ Merged **Merged:** 4/2/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix/lem-emb-err-rep` --- ### 📝 Commits (3) - [`a0f32db`](https://github.com/Mintplex-Labs/anything-llm/commit/a0f32dbd692bf67cf4e1d93ef189307dd8516a76) fix(lemonade): throw on embedding failures instead of returning empty vectors - [`0b6f6f7`](https://github.com/Mintplex-Labs/anything-llm/commit/0b6f6f705761dea05788562a0da5a836a12efe96) use class logger - [`55bfc50`](https://github.com/Mintplex-Labs/anything-llm/commit/55bfc50882432cac6a0cf41fb1af5631961e80dd) Merge branch 'master' into fix/lem-emb-err-rep ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/EmbeddingEngines/lemonade/index.js` (+4 -4) </details> ### 📄 Description [x] 🐛 fix (Bug fix) ### Relevant Issues resolves #5305 ### Description - Fix Lemonade embedder to throw on embedding failures instead of returning empty vectors. - Prevents documents from being falsely marked as successfully embedded when Lemonade errors occur. ### Visuals (if applicable) - N/A ### Additional Information - Aligns Lemonade error handling with other embedding engines. ### Developer Validations [ ] I ran yarn lint from the root of the repo & committed changes [ ] Relevant documentation has been updated (if applicable) [ ] I have tested my code functionality [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:16 -04:00
yindo closed this issue 2026-06-05 15:21:16 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?