Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5364] [MERGED] Remove illegal chars for Windows on files #5419

New Issue
Closed
opened 2026-06-05 15:21:18 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:18 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5364
Author: @timothycarambat
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @timothycarambat

Base: master ← Head: 5257-file-encoding-remove-illegal-chars

📝 Commits (1)

  • 5f01b3e Remove illegal chars for Windows on files

📊 Changes

4 files changed (+44 additions, -13 deletions)

View changed files

📝 collector/utils/files/index.js (+13 -3)
📝 server/utils/chats/apiChatHandler.js (+8 -3)
📝 server/utils/files/index.js (+16 -0)
📝 server/utils/files/multer.js (+7 -7)

📄 Description

Pull Request Type

  • ✨ feat (New feature)
  • 🐛 fix (Bug fix)
  • ♻️ refactor (Code refactoring without changing behavior)
  • 💄 style (UI style changes)
  • 🔨 chore (Build, CI, maintenance)
  • 📝 docs (Documentation updates)

Relevant Issues

resolves #5257

Description

Updates filename pre-sanitizing to remove simple chars that on windows cause issues downstream on desktop instances. This change will have no impact on Linux/MacOS or the native docker container.

Visuals (if applicable)

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated (if applicable)
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5364 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `5257-file-encoding-remove-illegal-chars` --- ### 📝 Commits (1) - [`5f01b3e`](https://github.com/Mintplex-Labs/anything-llm/commit/5f01b3e27cd59b378bfc1bf21a83f7a288ff3ddf) Remove illegal chars for Windows on files ### 📊 Changes **4 files changed** (+44 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `collector/utils/files/index.js` (+13 -3) 📝 `server/utils/chats/apiChatHandler.js` (+8 -3) 📝 `server/utils/files/index.js` (+16 -0) 📝 `server/utils/files/multer.js` (+7 -7) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat (New feature) - [ ] 🐛 fix (Bug fix) - [ ] ♻️ refactor (Code refactoring without changing behavior) - [ ] 💄 style (UI style changes) - [ ] 🔨 chore (Build, CI, maintenance) - [ ] 📝 docs (Documentation updates) ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #5257 ### Description Updates filename pre-sanitizing to remove simple chars that on windows cause issues downstream on desktop instances. This change will have no impact on Linux/MacOS or the native docker container. <!-- Describe the changes in this PR that are impactful to the repo. What problem does it solve? --> ### Visuals (if applicable) <!-- Add screenshots or screen recordings to demonstrate the changes, especially for UI updates. --> ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [ ] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated (if applicable) - [ ] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:18 -04:00
yindo closed this issue 2026-06-05 15:21:18 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?