Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5507] [CLOSED] fix: gate generic OpenAI tool stream usage reporting #5464

New Issue
Closed
opened 2026-06-05 15:21:26 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:26 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5507
Author: @haimingZZ
Created: 4/24/2026
Status: ❌ Closed

Base: master ← Head: fix/generic-openai-tool-usage-option

📝 Commits (1)

  • 8bddcaa fix: gate generic OpenAI tool stream usage reporting

📊 Changes

3 files changed (+73 additions, -4 deletions)

View changed files

➕ server/__tests__/utils/agents/aibitat/providers/helpers/tooled.test.js (+55 -0)
📝 server/utils/agents/aibitat/providers/genericOpenAi.js (+10 -1)
📝 server/utils/agents/aibitat/providers/helpers/tooled.js (+8 -3)

📄 Description

Summary

  • let tooledStream omit stream_options when a provider explicitly disables them
  • make the Generic OpenAI native tool-calling stream path honor GENERIC_OPEN_AI_REPORT_USAGE before sending include_usage
  • add a focused regression test for default usage reporting and provider-disabled stream options

Tests

  • node -c server/utils/agents/aibitat/providers/helpers/tooled.js
  • node -c server/utils/agents/aibitat/providers/genericOpenAi.js
  • npx jest server/__tests__/utils/agents/aibitat/providers/helpers/tooled.test.js --runInBand
  • git diff --check

Note: targeted npx eslint ... could not run in this checkout because the local install is missing ESLint config dependencies (@eslint/js).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5507 **Author:** [@haimingZZ](https://github.com/haimingZZ) **Created:** 4/24/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/generic-openai-tool-usage-option` --- ### 📝 Commits (1) - [`8bddcaa`](https://github.com/Mintplex-Labs/anything-llm/commit/8bddcaa1121ad837550caa56189d73e18dbe35f6) fix: gate generic OpenAI tool stream usage reporting ### 📊 Changes **3 files changed** (+73 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `server/__tests__/utils/agents/aibitat/providers/helpers/tooled.test.js` (+55 -0) 📝 `server/utils/agents/aibitat/providers/genericOpenAi.js` (+10 -1) 📝 `server/utils/agents/aibitat/providers/helpers/tooled.js` (+8 -3) </details> ### 📄 Description ## Summary - let `tooledStream` omit `stream_options` when a provider explicitly disables them - make the Generic OpenAI native tool-calling stream path honor `GENERIC_OPEN_AI_REPORT_USAGE` before sending `include_usage` - add a focused regression test for default usage reporting and provider-disabled stream options ## Tests - `node -c server/utils/agents/aibitat/providers/helpers/tooled.js` - `node -c server/utils/agents/aibitat/providers/genericOpenAi.js` - `npx jest server/__tests__/utils/agents/aibitat/providers/helpers/tooled.test.js --runInBand` - `git diff --check` Note: targeted `npx eslint ...` could not run in this checkout because the local install is missing ESLint config dependencies (`@eslint/js`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:26 -04:00
yindo closed this issue 2026-06-05 15:21:26 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?