Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5518] [MERGED] fix: invalid docs links in FileSystemSkillPanel #5467

New Issue
Closed
opened 2026-06-05 15:21:27 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:27 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5518
Author: @angelplusultra
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @timothycarambat

Base: master ← Head: 5517-invalid-docs-links-in-filesystemskillpanel-agents-settings

📝 Commits (4)

  • d906356 fix invalid documentation link
  • a416b82 fix link and trans i18n
  • 8a320f0 fix tag
  • e651771 Merge branch 'master' into 5517-invalid-docs-links-in-filesystemskillpanel-agents-settings

📊 Changes

25 files changed (+29 additions, -27 deletions)

View changed files

📝 frontend/src/locales/ar/common.js (+1 -1)
📝 frontend/src/locales/ca/common.js (+1 -1)
📝 frontend/src/locales/cs/common.js (+1 -1)
📝 frontend/src/locales/da/common.js (+1 -1)
📝 frontend/src/locales/de/common.js (+1 -1)
📝 frontend/src/locales/en/common.js (+1 -1)
📝 frontend/src/locales/es/common.js (+1 -1)
📝 frontend/src/locales/et/common.js (+1 -1)
📝 frontend/src/locales/fr/common.js (+1 -1)
📝 frontend/src/locales/he/common.js (+1 -1)
📝 frontend/src/locales/it/common.js (+1 -1)
📝 frontend/src/locales/ja/common.js (+1 -1)
📝 frontend/src/locales/ko/common.js (+1 -1)
📝 frontend/src/locales/lt/common.js (+1 -1)
📝 frontend/src/locales/lv/common.js (+1 -1)
📝 frontend/src/locales/nl/common.js (+1 -1)
📝 frontend/src/locales/pl/common.js (+1 -1)
📝 frontend/src/locales/pt_BR/common.js (+1 -1)
📝 frontend/src/locales/ro/common.js (+1 -1)
📝 frontend/src/locales/ru/common.js (+1 -1)

...and 5 more files

📄 Description

Pull Request Type

  • ✨ feat (New feature)
  • 🐛 fix (Bug fix)
  • ♻️ refactor (Code refactoring without changing behavior)
  • 💄 style (UI style changes)
  • 🔨 chore (Build, CI, maintenance)
  • 📝 docs (Documentation updates)

Relevant Issues

resolves #5517

Description

The "Learn more" link and the link inside the warning banner on the Filesystem agent skill panel (frontend/src/pages/Admin/Agents/FileSystemSkillPanel/index.jsx) were broken in two ways:

  1. They used react-router's <Link to="/docs/guides/agent-skills/filesystem-agent" />, which is a relative SPA path and caused the app to navigate internally to a non-existent route instead of opening the docs site.
  2. The underlying path didn't exist on the docs site either.

This PR:

  • Replaces both <Link to=...> usages with plain <a href="https://docs.useanything.com/agent/usage/file-system-agent"> anchors.
  • Adds target="_blank" + rel="noopener noreferrer" to match the external-link convention already used in the sibling Admin/Agents/MCPServers/index.jsx (also mitigates reverse-tabnabbing / referrer leakage).
  • Drops the now-unused Link import from react-router-dom.

Visuals (if applicable)

N/A — visual output is unchanged; only the link target/behavior was fixed.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated (if applicable)
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5518 **Author:** [@angelplusultra](https://github.com/angelplusultra) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `5517-invalid-docs-links-in-filesystemskillpanel-agents-settings` --- ### 📝 Commits (4) - [`d906356`](https://github.com/Mintplex-Labs/anything-llm/commit/d906356c73e6b6d289062f7e042d8aaa579dc515) fix invalid documentation link - [`a416b82`](https://github.com/Mintplex-Labs/anything-llm/commit/a416b8211be51ea2714fbd913e6cd3afe432a880) fix link and trans i18n - [`8a320f0`](https://github.com/Mintplex-Labs/anything-llm/commit/8a320f0dacd8ae94ca5d03b42e7d7b3f6d907894) fix tag - [`e651771`](https://github.com/Mintplex-Labs/anything-llm/commit/e651771429a771727731545b1555afacd2de899c) Merge branch 'master' into 5517-invalid-docs-links-in-filesystemskillpanel-agents-settings ### 📊 Changes **25 files changed** (+29 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/locales/ar/common.js` (+1 -1) 📝 `frontend/src/locales/ca/common.js` (+1 -1) 📝 `frontend/src/locales/cs/common.js` (+1 -1) 📝 `frontend/src/locales/da/common.js` (+1 -1) 📝 `frontend/src/locales/de/common.js` (+1 -1) 📝 `frontend/src/locales/en/common.js` (+1 -1) 📝 `frontend/src/locales/es/common.js` (+1 -1) 📝 `frontend/src/locales/et/common.js` (+1 -1) 📝 `frontend/src/locales/fr/common.js` (+1 -1) 📝 `frontend/src/locales/he/common.js` (+1 -1) 📝 `frontend/src/locales/it/common.js` (+1 -1) 📝 `frontend/src/locales/ja/common.js` (+1 -1) 📝 `frontend/src/locales/ko/common.js` (+1 -1) 📝 `frontend/src/locales/lt/common.js` (+1 -1) 📝 `frontend/src/locales/lv/common.js` (+1 -1) 📝 `frontend/src/locales/nl/common.js` (+1 -1) 📝 `frontend/src/locales/pl/common.js` (+1 -1) 📝 `frontend/src/locales/pt_BR/common.js` (+1 -1) 📝 `frontend/src/locales/ro/common.js` (+1 -1) 📝 `frontend/src/locales/ru/common.js` (+1 -1) _...and 5 more files_ </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat (New feature) - [x] 🐛 fix (Bug fix) - [ ] ♻️ refactor (Code refactoring without changing behavior) - [ ] 💄 style (UI style changes) - [ ] 🔨 chore (Build, CI, maintenance) - [ ] 📝 docs (Documentation updates) ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #5517 ### Description <!-- Describe the changes in this PR that are impactful to the repo. What problem does it solve? --> The "Learn more" link and the link inside the warning banner on the Filesystem agent skill panel (`frontend/src/pages/Admin/Agents/FileSystemSkillPanel/index.jsx`) were broken in two ways: 1. They used react-router's `<Link to="/docs/guides/agent-skills/filesystem-agent" />`, which is a relative SPA path and caused the app to navigate internally to a non-existent route instead of opening the docs site. 2. The underlying path didn't exist on the docs site either. This PR: - Replaces both `<Link to=...>` usages with plain `<a href="https://docs.useanything.com/agent/usage/file-system-agent">` anchors. - Adds `target="_blank"` + `rel="noopener noreferrer"` to match the external-link convention already used in the sibling `Admin/Agents/MCPServers/index.jsx` (also mitigates reverse-tabnabbing / referrer leakage). - Drops the now-unused `Link` import from `react-router-dom`. ### Visuals (if applicable) <!-- Add screenshots or screen recordings to demonstrate the changes, especially for UI updates. --> N/A — visual output is unchanged; only the link target/behavior was fixed. ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated (if applicable) - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:27 -04:00
yindo closed this issue 2026-06-05 15:21:27 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?