Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5513] [MERGED] fix(embedder): surface Mistral embedding failures #5468

New Issue
Closed
opened 2026-06-05 15:21:27 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:27 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5513
Author: @haimingZZ
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @timothycarambat

Base: master ← Head: fix/mistral-embedder-errors

📝 Commits (2)

  • e3c46a1 fix(embedder): surface Mistral embedding failures
  • ffadafd fix pr

📊 Changes

1 file changed (+9 additions, -12 deletions)

View changed files

📝 server/utils/EmbeddingEngines/mistral/index.js (+9 -12)

📄 Description

Summary

  • make Mistral embedding API failures throw instead of silently returning empty vectors
  • treat empty Mistral embedding responses as failures
  • add focused Mistral embedder tests for single-input failures, batch failures, and empty batch responses

Tests

  • git diff --check
  • node -c server/utils/EmbeddingEngines/mistral/index.js
  • npx jest server/__tests__/utils/EmbeddingEngines/mistral.test.js --runInBand

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5513 **Author:** [@haimingZZ](https://github.com/haimingZZ) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix/mistral-embedder-errors` --- ### 📝 Commits (2) - [`e3c46a1`](https://github.com/Mintplex-Labs/anything-llm/commit/e3c46a1ef9802e5c785f83c16495bb2f4ff2c28d) fix(embedder): surface Mistral embedding failures - [`ffadafd`](https://github.com/Mintplex-Labs/anything-llm/commit/ffadafdb44889b4f8dc079178667b25bba43fb0e) fix pr ### 📊 Changes **1 file changed** (+9 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/EmbeddingEngines/mistral/index.js` (+9 -12) </details> ### 📄 Description ## Summary - make Mistral embedding API failures throw instead of silently returning empty vectors - treat empty Mistral embedding responses as failures - add focused Mistral embedder tests for single-input failures, batch failures, and empty batch responses ## Tests - `git diff --check` - `node -c server/utils/EmbeddingEngines/mistral/index.js` - `npx jest server/__tests__/utils/EmbeddingEngines/mistral.test.js --runInBand` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:27 -04:00
yindo closed this issue 2026-06-05 15:21:27 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?