Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #5705] [CLOSED] fix: respect IME composition in prompt input #5540

New Issue
Closed
opened 2026-06-05 15:21:40 -04:00 by yindo · 0 comments
yindo commented 2026-06-05 15:21:40 -04:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/5705
Author: @RitwijParmar
Created: 5/26/2026
Status: ❌ Closed

Base: master ← Head: codex/anythingllm-ime-composition-guard

📝 Commits (1)

  • 07db706 fix: respect IME composition in prompt input

📊 Changes

1 file changed (+21 additions, -1 deletions)

View changed files

📝 frontend/src/components/WorkspaceChat/ChatContainer/PromptInput/index.jsx (+21 -1)

📄 Description

Summary

  • Guard prompt keyboard shortcuts while an IME composition is active, including Enter/keyCode 229 events from Android/Japanese keyboards.
  • Track composition start/end on the chat textarea and sync the final composed value/height after conversion completes.
  • Avoid adding undo snapshots while composition is in progress so the prompt does not interfere with conversion state.

Why

Issue #5696 reports Japanese IME input as unusable on Android. The prompt input currently handles Enter and tool-menu shortcuts before checking whether the key event belongs to an active IME composition, which can turn conversion/confirmation keystrokes into submit/menu behavior.

This PR addresses the Japanese IME input portion of #5696. It does not claim to fix the separate Android MCP tools issue from the same report.

Testing

  • yarn eslint src/components/WorkspaceChat/ChatContainer/PromptInput/index.jsx
  • yarn build

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/5705 **Author:** [@RitwijParmar](https://github.com/RitwijParmar) **Created:** 5/26/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `codex/anythingllm-ime-composition-guard` --- ### 📝 Commits (1) - [`07db706`](https://github.com/Mintplex-Labs/anything-llm/commit/07db7067fc2a71f7736a7f8050bf1f07d6bfce7a) fix: respect IME composition in prompt input ### 📊 Changes **1 file changed** (+21 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/WorkspaceChat/ChatContainer/PromptInput/index.jsx` (+21 -1) </details> ### 📄 Description ## Summary - Guard prompt keyboard shortcuts while an IME composition is active, including Enter/keyCode 229 events from Android/Japanese keyboards. - Track composition start/end on the chat textarea and sync the final composed value/height after conversion completes. - Avoid adding undo snapshots while composition is in progress so the prompt does not interfere with conversion state. ## Why Issue #5696 reports Japanese IME input as unusable on Android. The prompt input currently handles Enter and tool-menu shortcuts before checking whether the key event belongs to an active IME composition, which can turn conversion/confirmation keystrokes into submit/menu behavior. This PR addresses the Japanese IME input portion of #5696. It does not claim to fix the separate Android MCP tools issue from the same report. ## Testing - `yarn eslint src/components/WorkspaceChat/ChatContainer/PromptInput/index.jsx` - `yarn build` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-06-05 15:21:40 -04:00
yindo closed this issue 2026-06-05 15:21:40 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#5540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?