Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #1382] [BUG]: Embed API Improvements #882

New Issue
Closed
opened 2026-02-22 18:22:00 -05:00 by yindo · 4 comments
yindo commented 2026-02-22 18:22:00 -05:00
Owner
Copy Link
Copy Source

Originally created by @chalitbkb on GitHub (May 13, 2024).
Original GitHub issue: https://github.com/Mintplex-Labs/anything-llm/issues/1382

Originally assigned to: @shatfield4 on GitHub.

How are you running AnythingLLM?

All versions

What happened?

The API is unsafe when I use the 'embed' feature on my website. I can intercept all API requests, which I can then exploit anywhere. This needs to be fixed urgently. Even the 'sessionId' can be altered to bypass the existing limitations on the number of requests per session.

image

Are there known steps to reproduce?

No response

Originally created by @chalitbkb on GitHub (May 13, 2024). Original GitHub issue: https://github.com/Mintplex-Labs/anything-llm/issues/1382 Originally assigned to: @shatfield4 on GitHub. ### How are you running AnythingLLM? All versions ### What happened? The API is unsafe when I use the 'embed' feature on my website. I can intercept all API requests, which I can then exploit anywhere. This needs to be fixed urgently. Even the 'sessionId' can be altered to bypass the existing limitations on the number of requests per session. ![image](https://github.com/Mintplex-Labs/anything-llm/assets/32437546/b57f7be0-8c5a-4711-a62e-a34eb93c44ec) ### Are there known steps to reproduce? _No response_
yindo added the enhancementcore-team-only labels 2026-02-22 18:22:00 -05:00
yindo closed this issue 2026-02-22 18:22:00 -05:00
yindo commented 2026-02-22 18:22:00 -05:00
Author
Owner
Copy Link
Copy Source

@timothycarambat commented on GitHub (May 13, 2024):

The session ID is not a security feature. It is how chats are referenced to keep their history consistent on page loads. This exists in lieu of the ability to track by a user id.

@timothycarambat commented on GitHub (May 13, 2024): The session ID is not a security feature. It is how chats are referenced to keep their history consistent on page loads. This exists in lieu of the ability to track by a user id.
yindo commented 2026-02-22 18:22:00 -05:00
Author
Owner
Copy Link
Copy Source

@chalitbkb commented on GitHub (May 13, 2024):

The session ID is not a security feature. It is how chats are referenced to keep their history consistent on page loads. This exists in lieu of the ability to track by a user id.

I understand what you mean, but why can I intercept API requests and use them elsewhere? For example, I capture the URL endpoint, headers, and body to create a backend with Node.js. Then I try sending a POST request. It can send the request, but from a security standard perspective, this shouldn't be the case. You should encrypt the data using something like the 'crypto-js module' or similar before sending the request to prevent unauthorized use elsewhere.

I believe that if I were to examine the chatbox of others using the 'anything-llm' service, I am confident that I could intercept their requests and then use them elsewhere, which means I could send unlimited requests anywhere.

@chalitbkb commented on GitHub (May 13, 2024): > The session ID is not a security feature. It is how chats are referenced to keep their history consistent on page loads. This exists in lieu of the ability to track by a user id. I understand what you mean, but why can I intercept API requests and use them elsewhere? For example, I capture the URL endpoint, headers, and body to create a backend with Node.js. Then I try sending a POST request. It can send the request, but from a security standard perspective, this shouldn't be the case. You should encrypt the data using something like the 'crypto-js module' or similar before sending the request to prevent unauthorized use elsewhere. I believe that if I were to examine the chatbox of others using the 'anything-llm' service, I am confident that I could intercept their requests and then use them elsewhere, which means I could send unlimited requests anywhere.
yindo commented 2026-02-22 18:22:00 -05:00
Author
Owner
Copy Link
Copy Source

@timothycarambat commented on GitHub (May 13, 2024):

This would just be CORS blocking from the Origin header, which of course can always be spoofed with tools like Burpsuite. The embed chat functionality was added because many people wanted to just expose something like this but we warn this in the embed config styleguide https://github.com/Mintplex-Labs/anything-llm/tree/master/embed#security

I dont disagree with you that this is an annoyance and likely should not be enabled. Does the domain allowlist not improve this? https://github.com/Mintplex-Labs/anything-llm/blob/2fabc845789fb60f078c092fb6b5bd6aed1c3475/server/utils/middleware/embedMiddleware.js#L65

It does not prevent a session ID rotation or replay. We could add an IP logger and restrict based on IP, but this still does not make that whole endpoint more robust since all of these client side things can be spoofed? I think that could be a good improvement though?

@timothycarambat commented on GitHub (May 13, 2024): This would just be CORS blocking from the `Origin` header, which of course can always be spoofed with tools like Burpsuite. The embed chat functionality was added because many people wanted to just expose something like this but we warn this in the embed config styleguide https://github.com/Mintplex-Labs/anything-llm/tree/master/embed#security I **dont disagree** with you that this is an annoyance and likely should not be enabled. Does the domain allowlist not improve this? https://github.com/Mintplex-Labs/anything-llm/blob/2fabc845789fb60f078c092fb6b5bd6aed1c3475/server/utils/middleware/embedMiddleware.js#L65 It does not prevent a session ID rotation or replay. We could add an IP logger and restrict based on IP, but this still does not make that whole endpoint more robust since all of these client side things can be spoofed? I think that could be a good improvement though?
yindo commented 2026-02-22 18:22:00 -05:00
Author
Owner
Copy Link
Copy Source

@chalitbkb commented on GitHub (May 13, 2024):

This would just be CORS blocking from the Origin header, which of course can always be spoofed with tools like Burpsuite. The embed chat functionality was added because many people wanted to just expose something like this but we warn this in the embed config styleguide https://github.com/Mintplex-Labs/anything-llm/tree/master/embed#security

I dont disagree with you that this is an annoyance and likely should not be enabled. Does the domain allowlist not improve this? https://github.com/Mintplex-Labs/anything-llm/blob/2fabc845789fb60f078c092fb6b5bd6aed1c3475/server/utils/middleware/embedMiddleware.js#L65

It does not prevent a session ID rotation or replay. We could add an IP logger and restrict based on IP, but this still does not make that whole endpoint more robust since all of these client side things can be spoofed? I think that could be a good improvement though?

Yes, sir, you understand correctly just as you thought.

@chalitbkb commented on GitHub (May 13, 2024): > This would just be CORS blocking from the `Origin` header, which of course can always be spoofed with tools like Burpsuite. The embed chat functionality was added because many people wanted to just expose something like this but we warn this in the embed config styleguide https://github.com/Mintplex-Labs/anything-llm/tree/master/embed#security > > > > I **dont disagree** with you that this is an annoyance and likely should not be enabled. Does the domain allowlist not improve this? https://github.com/Mintplex-Labs/anything-llm/blob/2fabc845789fb60f078c092fb6b5bd6aed1c3475/server/utils/middleware/embedMiddleware.js#L65 > > > > It does not prevent a session ID rotation or replay. We could add an IP logger and restrict based on IP, but this still does not make that whole endpoint more robust since all of these client side things can be spoofed? I think that could be a good improvement though? Yes, sir, you understand correctly just as you thought.
yindo changed title from [BUG]: Embed API Improvements to [GH-ISSUE #1382] [BUG]: Embed API Improvements 2026-06-05 14:37:43 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label core-team-only enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?