Files
langchain-python/langchain
Mike Salvatore cbd759aaeb Fix inconsistent logging_and_data_dir parameter in AwaDB (#6775)
## Description

Tag maintainer: @rlancemartin, @eyurtsev 

### log_and_data_dir
`AwaDB.__init__()` accepts a parameter named `log_and_data_dir`. But
`AwaDB.from_texts()` and `AwaDB.from_documents()` accept a parameter
named `logging_and_data_dir`. This inconsistency in this parameter name
can lead to confusion on the part of the caller.

This PR renames `logging_and_data_dir` to `log_and_data_dir` to make all
functions consistent with the constructor.

### embedding

`AwaDB.__init__()` accepts a parameter named `embedding_model`. But
`AwaDB.from_texts()` and `AwaDB.from_documents()` accept a parameter
named `embeddings`. This inconsistency in this parameter name can lead
to confusion on the part of the caller.

This PR renames `embedding_model` to `embeddings` to make AwaDB's
constructor consistent with the classmethod "constructors" as specified
by `VectorStore` abstract base class.
2023-06-28 23:06:52 -07:00
..
2023-06-26 00:49:32 -07:00
2023-06-18 16:55:18 -07:00
2023-06-28 23:04:11 -07:00
2023-06-20 22:07:00 -07:00
2023-06-28 23:04:11 -07:00
2023-06-28 23:04:11 -07:00
2023-06-11 15:51:28 -07:00
2023-06-08 21:15:14 -07:00
2023-06-03 16:48:48 -07:00
2022-11-12 11:22:32 -08:00
2023-02-20 21:15:45 -08:00