[PR #66] [CLOSED] Update index.tsx #125

Closed
opened 2026-02-15 16:30:22 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/vector-admin/pull/66
Author: @carrigan223
Created: 10/9/2023
Status: Closed

Base: masterHead: patch-1


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 frontend/src/pages/DocumentView/FragmentList/index.tsx (+1 -1)

📄 Description

Seemed to be calling truncate regardless of whether the property was present which caused truncate to call .length against a null, do not have running locally so could not verify in browser if the change was correct, i created a issue for it https://github.com/Mintplex-Labs/vector-admin/issues/65 please verify if my guess was correct. I called an if against that property (data.metadata.text) and just provided place holder text matching the string below if a falsy value was found. Hope i could help.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/vector-admin/pull/66 **Author:** [@carrigan223](https://github.com/carrigan223) **Created:** 10/9/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`570982e`](https://github.com/Mintplex-Labs/vector-admin/commit/570982e36d36f7d0223165aeb26653487c94ef76) Update index.tsx ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/DocumentView/FragmentList/index.tsx` (+1 -1) </details> ### 📄 Description Seemed to be calling truncate regardless of whether the property was present which caused truncate to call .length against a null, do not have running locally so could not verify in browser if the change was correct, i created a issue for it https://github.com/Mintplex-Labs/vector-admin/issues/65 please verify if my guess was correct. I called an if against that property (data.metadata.text) and just provided place holder text matching the string below if a falsy value was found. Hope i could help. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 16:30:22 -05:00
yindo closed this issue 2026-02-15 16:30:22 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/vector-admin#125