mirror of
https://github.com/Mintplex-Labs/vector-admin.git
synced 2026-07-18 18:14:31 -04:00
[PR #66] [CLOSED] Update index.tsx #125
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Mintplex-Labs/vector-admin/pull/66
Author: @carrigan223
Created: 10/9/2023
Status: ❌ Closed
Base:
master← Head:patch-1📝 Commits (1)
570982eUpdate index.tsx📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
frontend/src/pages/DocumentView/FragmentList/index.tsx(+1 -1)📄 Description
Seemed to be calling truncate regardless of whether the property was present which caused truncate to call .length against a null, do not have running locally so could not verify in browser if the change was correct, i created a issue for it https://github.com/Mintplex-Labs/vector-admin/issues/65 please verify if my guess was correct. I called an if against that property (data.metadata.text) and just provided place holder text matching the string below if a falsy value was found. Hope i could help.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.