[PR #118] [MERGED] V2 delete embedding modal #311

Closed
opened 2026-02-23 17:21:13 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/vector-admin/pull/118
Author: @shatfield4
Created: 1/11/2024
Status: Merged
Merged: 1/11/2024
Merged by: @timothycarambat

Base: ui-v2Head: v2-delete-embedding-modal


📝 Commits (3)

  • 1206084 update delete embedding modal to match ui v2
  • 7aa20d6 remove unneeded files
  • d31f106 remove commented out code

📊 Changes

2 files changed (+37 additions, -34 deletions)

View changed files

📝 .gitignore (+3 -1)
📝 frontend/src/pages/DocumentView/FragmentList/DeleteEmbeddingConfirmation/index.tsx (+34 -33)

📄 Description

Pull Request Type

  • feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #114

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • updated delete embedding modal to match ui v2

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/vector-admin/pull/118 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 1/11/2024 **Status:** ✅ Merged **Merged:** 1/11/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `ui-v2` ← **Head:** `v2-delete-embedding-modal` --- ### 📝 Commits (3) - [`1206084`](https://github.com/Mintplex-Labs/vector-admin/commit/1206084e195edae1e7417d1eab2327e508e49e89) update delete embedding modal to match ui v2 - [`7aa20d6`](https://github.com/Mintplex-Labs/vector-admin/commit/7aa20d6a4a596ad237842d1dec0e952ff388be17) remove unneeded files - [`d31f106`](https://github.com/Mintplex-Labs/vector-admin/commit/d31f10672d24cc994d2cb23d6b8449b010285673) remove commented out code ### 📊 Changes **2 files changed** (+37 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -1) 📝 `frontend/src/pages/DocumentView/FragmentList/DeleteEmbeddingConfirmation/index.tsx` (+34 -33) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [ ] 🐛 fix - [ ] ♻️ refactor - [x] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #114 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - updated delete embedding modal to match ui v2 ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [ ] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-23 17:21:13 -05:00
yindo closed this issue 2026-02-23 17:21:13 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/vector-admin#311