From 3eadf6cc0af53eb327ab4ddd5dcb8ecd8f403850 Mon Sep 17 00:00:00 2001 From: Eljees <57435526+Eljees@users.noreply.github.com> Date: Mon, 10 Aug 2026 02:57:21 +0300 Subject: [PATCH] fix(rules): match the literal mode argument in getSharedPreferences (#2638) The world readable/writable patterns matched any argument list ending with 1 or 2, so decompiled identifiers such as var1, var2 or mode2 were reported as world permissions. Signed-off-by: Eljees <3.14hell@gmail.com> Co-authored-by: Ajin Abraham --- mobsf/StaticAnalyzer/views/android/rules/android_rules.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mobsf/StaticAnalyzer/views/android/rules/android_rules.yaml b/mobsf/StaticAnalyzer/views/android/rules/android_rules.yaml index 5fd33887..b5a2411a 100644 --- a/mobsf/StaticAnalyzer/views/android/rules/android_rules.yaml +++ b/mobsf/StaticAnalyzer/views/android/rules/android_rules.yaml @@ -612,7 +612,7 @@ type: RegexOr pattern: - MODE_WORLD_WRITABLE - - \.getSharedPreferences\(.{0,50}?2\) + - \.getSharedPreferences\([^)]{0,50}?,\s*2\s*\) - 'openFileOutput\(\s*".{1,48}"\s*,\s*2\s*\)' severity: high input_case: exact @@ -627,7 +627,7 @@ type: RegexOr pattern: - MODE_WORLD_READABLE - - \.getSharedPreferences\(.{0,50}?1\) + - \.getSharedPreferences\([^)]{0,50}?,\s*1\s*\) - 'openFileOutput\(\s*".{1,48}"\s*,\s*1\s*\)' severity: high input_case: exact