From 95e647754fcbff5b33f96678aa7494b0677a5fc2 Mon Sep 17 00:00:00 2001 From: jinye Date: Mon, 2 Nov 2026 11:42:31 +0800 Subject: [PATCH] fix(managed-agent): keep javadoc valid after the module split (#16099) The Maven module split promoted the ECMAScript number formatter to public API and moved the external runtime kinds into the contracts module. Both changes left javadoc that doclint now rejects: - The formatter's comment compares against 1e21 with a bare "<", which doclint reads as the start of an HTML tag. While the method was package-private the comment was never documented, so it went unnoticed. - The external provisioner links to the kinds class without importing it. That resolved when both lived in the same package and no longer does. The release profile is the only place that runs javadoc, so the failure surfaced while publishing rather than in PR CI, and the managed runtime JAR for the latest release was never built. --- .../runtimebroker/provisioning/ExternalRuntimeProvisioner.java | 1 + .../managedagent/contracts/event/ManagedEventEnvelopes.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/managed-agent-server/adapters/src/main/java/com/alibaba/qwen/code/runtimebroker/provisioning/ExternalRuntimeProvisioner.java b/packages/managed-agent-server/adapters/src/main/java/com/alibaba/qwen/code/runtimebroker/provisioning/ExternalRuntimeProvisioner.java index 4580f34c9b6..cc25d771c08 100644 --- a/packages/managed-agent-server/adapters/src/main/java/com/alibaba/qwen/code/runtimebroker/provisioning/ExternalRuntimeProvisioner.java +++ b/packages/managed-agent-server/adapters/src/main/java/com/alibaba/qwen/code/runtimebroker/provisioning/ExternalRuntimeProvisioner.java @@ -12,6 +12,7 @@ import com.alibaba.qwen.code.runtimebroker.RuntimeProvisioner; import com.alibaba.qwen.code.runtimebroker.RuntimeResourceHandle; import com.alibaba.qwen.code.runtimebroker.RuntimeScope; import com.alibaba.qwen.code.runtimebroker.adapter.HttpRuntimeTransport; +import com.alibaba.qwen.code.runtimebroker.protocol.ExternalRuntimeKinds; import com.alibaba.qwen.code.runtimebroker.spi.ExternalRuntimeClient; import org.apache.commons.codec.digest.DigestUtils; diff --git a/packages/managed-agent-server/contracts/src/main/java/com/alibaba/qwen/code/managedagent/contracts/event/ManagedEventEnvelopes.java b/packages/managed-agent-server/contracts/src/main/java/com/alibaba/qwen/code/managedagent/contracts/event/ManagedEventEnvelopes.java index 812584a1e9b..39c43751325 100644 --- a/packages/managed-agent-server/contracts/src/main/java/com/alibaba/qwen/code/managedagent/contracts/event/ManagedEventEnvelopes.java +++ b/packages/managed-agent-server/contracts/src/main/java/com/alibaba/qwen/code/managedagent/contracts/event/ManagedEventEnvelopes.java @@ -332,7 +332,7 @@ public final class ManagedEventEnvelopes { /** * ECMAScript Number::toString (radix 10) faithfully, so the digest matches * the TypeScript side byte-for-byte. The thresholds are the spec's: - * decimal form while 1e-6 ≤ |x| < 1e21, exponential outside it. + * decimal form while 1e-6 ≤ |x| < 1e21, exponential outside it. */ public static String jsNumberToString(double d) { if (d == 0) {