From bb0d1f0a00a60a84702920ccc2ecdc4c69518789 Mon Sep 17 00:00:00 2001 From: FlexBy420 <68403300+FlexBy420@users.noreply.github.com> Date: Sat, 15 Nov 2025 16:28:13 +0100 Subject: [PATCH 1/2] add detection for mounted disc/iso for macOS --- ...LogParserResultFormatter.GeneralNotesSection.cs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs index 1b90979c..088e97b8 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs @@ -116,10 +116,16 @@ internal static partial class LogParserResult notes.Add("❌ Disc version of the game inside the `/dev_hdd0/game/` directory"); if (!string.IsNullOrEmpty(serial) && isElf) notes.Add($"⚠️ Retail game booted directly through `{Path.GetFileName(elfBootPath)}`, which is not recommended"); - if (items["os_type"] == "Windows" - && items["mounted_dev_bdvd"] is {Length: >0} mountedBdvd - && mountedBdvd.TrimEnd('/').EndsWith(':')) - notes.Add("⚠️ Booting directly from blu-ray disc is not supported, please make a proper game dump"); + if (items["mounted_dev_bdvd"] is { Length: > 0 } mountedBdvd) + { + var bdvdPath = mountedBdvd.TrimEnd('/'); + bool isWin = items["os_type"] == "Windows" && bdvdPath.EndsWith(':');\ + bool isMac = items["os_type"] == "MacOS" && bdvdPath.StartsWith("/Volumes/", StringComparison.OrdinalIgnoreCase); + if (isWin || isMac) + { + notes.Add("⚠️ Booting directly from blu-ray disc is not supported, please make a proper game dump"); + } + } if (items["log_from_ui"] is not null) notes.Add("ℹ️ The log is a copy from UI, please upload the full file created by RPCS3"); From 2f68a3a0bc96358a6a52b80065f7f246ffe808da Mon Sep 17 00:00:00 2001 From: FlexBy420 <68403300+FlexBy420@users.noreply.github.com> Date: Sat, 15 Nov 2025 16:31:49 +0100 Subject: [PATCH 2/2] remove misplaced \ --- .../LogParserResultFormatter.GeneralNotesSection.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs index 088e97b8..ea1ea1a4 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs @@ -119,7 +119,7 @@ internal static partial class LogParserResult if (items["mounted_dev_bdvd"] is { Length: > 0 } mountedBdvd) { var bdvdPath = mountedBdvd.TrimEnd('/'); - bool isWin = items["os_type"] == "Windows" && bdvdPath.EndsWith(':');\ + bool isWin = items["os_type"] == "Windows" && bdvdPath.EndsWith(':'); bool isMac = items["os_type"] == "MacOS" && bdvdPath.StartsWith("/Volumes/", StringComparison.OrdinalIgnoreCase); if (isWin || isMac) {