From 7ff41727f67363baf53e57f894dd26fd1c2fd3d8 Mon Sep 17 00:00:00 2001 From: FlexBy420 <68403300+FlexBy420@users.noreply.github.com> Date: Fri, 4 Jul 2025 16:59:47 +0200 Subject: [PATCH 1/3] Check Pdf1 ppu hashes too instead of only Pdf2 --- .../LogParserResultFormatter.WeirdSettingsSection.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs index 9372b43b..47d17292 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs @@ -1183,7 +1183,7 @@ internal static partial class LogParserResult if (items["frame_limit"] is not null and not "Off") notes.Add("⚠️ `Frame Limiter` should be `Off`"); - if (!ppuHashes.Overlaps(KnownPdf2ndPatches)) + if (!ppuHashes.Overlaps(KnownPdf2ndPatches) && !ppuHashes.Overlaps(KnownPdfPatches)) generalNotes.Add("🤔 Very interesting version of the game you got there"); } From 72f3b9abe1ff8ba2946dee18a483583b0b89e3b1 Mon Sep 17 00:00:00 2001 From: FlexBy420 <68403300+FlexBy420@users.noreply.github.com> Date: Fri, 4 Jul 2025 21:00:00 +0200 Subject: [PATCH 2/3] add pdf1 demo hashes --- .../LogParserResultFormatter.WeirdSettingsSection.cs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs index 47d17292..a51ea80f 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs @@ -1140,14 +1140,18 @@ internal static partial class LogParserResult [ "BLJM60527", "BLUS31319", "BLAS50576", "NPEB01393", "NPUB31241", "NPHB00559", "NPJB00287", + "NPEB90498", "NPJB90588", "NPUB90958", // demo ]; private static readonly HashSet KnownPdfPatches = new(StringComparer.InvariantCultureIgnoreCase) { - "f3227f57ec001582b253035fd90de77f05ead470", - "c02e3b52e3d75f52f76fb8f0fb5be7ca4d921949", - "1105af0a4d6a4a1481930c6f3090c476cde06c4c", + "f3227f57ec001582b253035fd90de77f05ead470", // US + "c02e3b52e3d75f52f76fb8f0fb5be7ca4d921949", // EU + "1105af0a4d6a4a1481930c6f3090c476cde06c4c", // JP + "b0e0b8683e771af7d47758d2ba16629752741a86", // NPEB90498 + "3b862822377252f92731dfd2ba39a809de09a987", // NPJB90588 + "ccbe4a3f3e934995c7526610d9fcb5282dd64044", // NPUB90958 }; private static readonly HashSet Pdf2ndIds = From 66ebb06bdc5a5b571634414c869cfafacec2de27 Mon Sep 17 00:00:00 2001 From: 13xforever Date: Sat, 5 Jul 2025 22:02:46 +0500 Subject: [PATCH 3/3] only check known hashes for pdf2 --- .../LogParserResultFormatter.WeirdSettingsSection.cs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs index a51ea80f..a68b399a 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.WeirdSettingsSection.cs @@ -1177,17 +1177,15 @@ internal static partial class LogParserResult if (!PdfIds.Contains(serial) && !Pdf2ndIds.Contains(serial)) return; - if (!ppuPatches.Any()) + if (ppuPatches.Count is 0) { - if (ppuHashes.Overlaps(KnownPdfPatches)) - generalNotes.Add("ℹ️ This game has an FPS unlock patch"); - else if (ppuHashes.Overlaps(KnownPdf2ndPatches)) + if (ppuHashes.Overlaps(KnownPdfPatches) || ppuHashes.Overlaps(KnownPdf2ndPatches)) generalNotes.Add("ℹ️ This game has an FPS unlock patch"); } if (items["frame_limit"] is not null and not "Off") notes.Add("⚠️ `Frame Limiter` should be `Off`"); - if (!ppuHashes.Overlaps(KnownPdf2ndPatches) && !ppuHashes.Overlaps(KnownPdfPatches)) + if (Pdf2ndIds.Contains(serial) && !ppuHashes.Overlaps(KnownPdf2ndPatches)) generalNotes.Add("🤔 Very interesting version of the game you got there"); }