From ac55badb77cad25020140237dfd05d9be490649f Mon Sep 17 00:00:00 2001 From: 13xforever Date: Fri, 19 Sep 2025 16:16:02 +0500 Subject: [PATCH] update broken build checks --- .../LogParserResultFormatter.GeneralNotesSection.cs | 8 ++++---- .../Utils/ResultFormatters/LogParserResultFormatter.cs | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs index 844b8246..f0fa3506 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.GeneralNotesSection.cs @@ -478,8 +478,7 @@ internal static partial class LogParserResult timeDeltaStr = "outdated"; if (items["os_type"] is not "Windows" - || !TryGetRpcs3Version(items, out var v) - || v < NonBrokenMsvcOptimizationBuild) + || !TryGetRpcs3Version(items, out var v)) { notes.Add($"{prefix} This RPCS3 build is {timeDeltaStr}, please consider updating it"); } @@ -499,9 +498,10 @@ internal static partial class LogParserResult } if (items["os_type"] is "Windows" && TryGetRpcs3Version(items, out var v2) - && v2 > NonBrokenMsvcOptimizationBuild) + && v2 >= BrokenMsvcOptimizationBuild + && v2 < UnBrokenMsvcOptimizationBuild) { - notes.Add($"⚠️ Please downgrade to build v0.0.37-18022 for the Windows"); + notes.Add($"⚠️ This build for Windows is known to be broken, please update"); } if (DesIds.Contains(serial)) diff --git a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.cs b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.cs index fda949cf..180a409c 100644 --- a/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.cs +++ b/CompatBot/Utils/ResultFormatters/LogParserResultFormatter.cs @@ -67,7 +67,8 @@ internal static partial class LogParserResult private static readonly Version FixedTlouRcbBuild = new(0, 0, 21, 13432); // the best I got was "it was fixed more than a year ago", so it's just a random build from a year ago private static readonly Version FixedSimpsonsBuild = new(0, 0, 29, 15470); private static readonly Version FixedSpuGetllarOptimizationBuild = new(0, 0, 36, 17938); - private static readonly Version NonBrokenMsvcOptimizationBuild = new(0, 0, 37, 18022); + private static readonly Version BrokenMsvcOptimizationBuild = new(0, 0, 37, 18023); + private static readonly Version UnBrokenMsvcOptimizationBuild = new(0, 0, 37, 18147); private static readonly Dictionary RsxPresentModeMap = new() {