Commit Graph

4 Commits

Author SHA1 Message Date
Dean Michael Berris
69da26fa1d [XRay] Remove unused reference
The reference was only used in the assertion.

Follow-up on D51723.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341771 91177308-0d34-0410-b5e6-96231b3b80d8
2018-09-10 02:57:05 +00:00
Dean Michael Berris
229ad4c6b0 [XRay] Add a BlockVerifier visitor for FDR Records
Summary:
This patch implements a `BlockVerifier` type which enforces the
invariants of the log structure of FDR mode logs on a per-block basis.
This ensures that the data we encounter from an FDR mode log
semantically correct (i.e. that records follow the documented "grammar"
for FDR mode log records).

This is another part of the refactoring of D50441.

This is a slightly modified version of rL341628, avoiding the
`std::tuple<...>` constructor that is not constexpr in C++11.

Reviewers: mboerger, eizan

Subscribers: mgorny, hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D51723

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341769 91177308-0d34-0410-b5e6-96231b3b80d8
2018-09-10 02:35:25 +00:00
Dean Michael Berris
30734541ee Revert "[XRay] Add a BlockVerifier visitor for FDR Records"
This reverts commit r341628.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341631 91177308-0d34-0410-b5e6-96231b3b80d8
2018-09-07 03:38:26 +00:00
Dean Michael Berris
5d32049f06 [XRay] Add a BlockVerifier visitor for FDR Records
Summary:
This patch implements a `BlockVerifier` type which enforces the
invariants of the log structure of FDR mode logs on a per-block basis.
This ensures that the data we encounter from an FDR mode log
semantically correct (i.e. that records follow the documented "grammar"
for FDR mode log records).

This is another part of the refactoring of D50441.

Reviewers: mboerger, eizan

Subscribers: mgorny, hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D51723

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341628 91177308-0d34-0410-b5e6-96231b3b80d8
2018-09-07 02:25:06 +00:00