mirror of
https://github.com/RPCS3/llvm.git
synced 2026-01-31 01:25:19 +01:00
c312996e7a
Codegen prepare sinks comparisons close to a user is we have only one register for conditions. For AMDGPU we have many SGPRs capable to hold vector conditions. Changed BE to report we have many condition registers. That way IR LICM pass would hoist an invariant comparison out of a loop and codegen prepare will not sink it. With that done a condition is calculated in one block and used in another. Current behavior is to store workitem's condition in a VGPR using v_cndmask and then restore it with yet another v_cmp instruction from that v_cndmask's result. To mitigate the issue a forward propagation of a v_cmp 64 bit result to an user is implemented. Additional side effect of this is that we may consume less VGPRs in a cost of more SGPRs in case if holding of multiple conditions is needed, and that is a clear win in most cases. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286171 91177308-0d34-0410-b5e6-96231b3b80d8
47 lines
1.7 KiB
LLVM
47 lines
1.7 KiB
LLVM
; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck %s
|
|
|
|
; Check that invariant compare is hoisted out of the loop.
|
|
; At the same time condition shall not be serialized into a VGPR and deserialized later
|
|
; using another v_cmp + v_cndmask, but used directly in s_and_saveexec_b64.
|
|
|
|
; CHECK: v_cmp_{{..}}_u32_e64 [[COND:s\[[0-9]+:[0-9]+\]]]
|
|
; CHECK: BB0_1:
|
|
; CHECK-NOT: v_cmp
|
|
; CHECK_NOT: v_cndmask
|
|
; CHECK: s_and_saveexec_b64 s[{{[[0-9]+:[0-9]+}}], [[COND]]
|
|
; CHECK: BB0_2:
|
|
|
|
define amdgpu_kernel void @hoist_cond(float addrspace(1)* nocapture %arg, float addrspace(1)* noalias nocapture readonly %arg1, i32 %arg3, i32 %arg4) {
|
|
bb:
|
|
%tmp = tail call i32 @llvm.amdgcn.workitem.id.x() #0
|
|
%tmp5 = icmp ult i32 %tmp, %arg3
|
|
br label %bb1
|
|
|
|
bb1: ; preds = %bb3, %bb
|
|
%tmp7 = phi i32 [ %arg4, %bb ], [ %tmp16, %bb3 ]
|
|
%tmp8 = phi float [ 0.000000e+00, %bb ], [ %tmp15, %bb3 ]
|
|
br i1 %tmp5, label %bb2, label %bb3
|
|
|
|
bb2: ; preds = %bb1
|
|
%tmp10 = zext i32 %tmp7 to i64
|
|
%tmp11 = getelementptr inbounds float, float addrspace(1)* %arg1, i64 %tmp10
|
|
%tmp12 = load float, float addrspace(1)* %tmp11, align 4
|
|
br label %bb3
|
|
|
|
bb3: ; preds = %bb2, %bb1
|
|
%tmp14 = phi float [ %tmp12, %bb2 ], [ 0.000000e+00, %bb1 ]
|
|
%tmp15 = fadd float %tmp8, %tmp14
|
|
%tmp16 = add i32 %tmp7, -1
|
|
%tmp17 = icmp eq i32 %tmp16, 0
|
|
br i1 %tmp17, label %bb4, label %bb1
|
|
|
|
bb4: ; preds = %bb3
|
|
store float %tmp15, float addrspace(1)* %arg, align 4
|
|
ret void
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare i32 @llvm.amdgcn.workitem.id.x() #0
|
|
|
|
attributes #0 = { nounwind readnone }
|