mirror of
https://github.com/RPCS3/llvm.git
synced 2026-01-31 01:25:19 +01:00
bfc1e953bc
This reverts r317579, originally committed as r317100.
There is a design issue with marking CFI instructions duplicatable. Not
all targets support the CFIInstrInserter pass, and targets like Darwin
can't cope with duplicated prologue setup CFI instructions. The compact
unwind info emission fails.
When the following code is compiled for arm64 on Mac at -O3, the CFI
instructions end up getting tail duplicated, which causes compact unwind
info emission to fail:
int a, c, d, e, f, g, h, i, j, k, l, m;
void n(int o, int *b) {
if (g)
f = 0;
for (; f < o; f++) {
m = a;
if (l > j * k > i)
j = i = k = d;
h = b[c] - e;
}
}
We get assembly that looks like this:
; BB#1: ; %if.then
Lloh3:
adrp x9, _f@GOTPAGE
Lloh4:
ldr x9, [x9, _f@GOTPAGEOFF]
mov w8, wzr
Lloh5:
str wzr, [x9]
stp x20, x19, [sp, #-16]! ; 8-byte Folded Spill
.cfi_def_cfa_offset 16
.cfi_offset w19, -8
.cfi_offset w20, -16
cmp w8, w0
b.lt LBB0_3
b LBB0_7
LBB0_2: ; %entry.if.end_crit_edge
Lloh6:
adrp x8, _f@GOTPAGE
Lloh7:
ldr x8, [x8, _f@GOTPAGEOFF]
Lloh8:
ldr w8, [x8]
stp x20, x19, [sp, #-16]! ; 8-byte Folded Spill
.cfi_def_cfa_offset 16
.cfi_offset w19, -8
.cfi_offset w20, -16
cmp w8, w0
b.ge LBB0_7
LBB0_3: ; %for.body.lr.ph
Note the multiple .cfi_def* directives. Compact unwind info emission
can't handle that.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@317726 91177308-0d34-0410-b5e6-96231b3b80d8
87 lines
2.1 KiB
LLVM
87 lines
2.1 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc -verify-machineinstrs < %s -mtriple=i686-unknown-unknown -mattr=+rtm | FileCheck %s --check-prefix=X86
|
|
; RUN: llc -verify-machineinstrs < %s -mtriple=x86_64-unknown-unknown -mattr=+rtm | FileCheck %s --check-prefix=X64
|
|
|
|
declare i32 @llvm.x86.xbegin() nounwind
|
|
declare void @llvm.x86.xend() nounwind
|
|
declare void @llvm.x86.xabort(i8) nounwind
|
|
declare void @f1()
|
|
|
|
define i32 @test_xbegin() nounwind uwtable {
|
|
; X86-LABEL: test_xbegin:
|
|
; X86: # BB#0: # %entry
|
|
; X86-NEXT: xbegin .LBB0_2
|
|
; X86-NEXT: # BB#1: # %entry
|
|
; X86-NEXT: movl $-1, %eax
|
|
; X86: .LBB0_2: # %entry
|
|
; X86-NEXT: # XABORT DEF
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_xbegin:
|
|
; X64: # BB#0: # %entry
|
|
; X64-NEXT: xbegin .LBB0_2
|
|
; X64-NEXT: # BB#1: # %entry
|
|
; X64-NEXT: movl $-1, %eax
|
|
; X64: .LBB0_2: # %entry
|
|
; X64-NEXT: # XABORT DEF
|
|
; X64-NEXT: retq
|
|
entry:
|
|
%0 = tail call i32 @llvm.x86.xbegin() nounwind
|
|
ret i32 %0
|
|
}
|
|
|
|
define void @test_xend() nounwind uwtable {
|
|
; X86-LABEL: test_xend:
|
|
; X86: # BB#0: # %entry
|
|
; X86-NEXT: xend
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_xend:
|
|
; X64: # BB#0: # %entry
|
|
; X64-NEXT: xend
|
|
; X64-NEXT: retq
|
|
entry:
|
|
tail call void @llvm.x86.xend() nounwind
|
|
ret void
|
|
}
|
|
|
|
define void @test_xabort() nounwind uwtable {
|
|
; X86-LABEL: test_xabort:
|
|
; X86: # BB#0: # %entry
|
|
; X86-NEXT: xabort $2
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_xabort:
|
|
; X64: # BB#0: # %entry
|
|
; X64-NEXT: xabort $2
|
|
; X64-NEXT: retq
|
|
entry:
|
|
tail call void @llvm.x86.xabort(i8 2)
|
|
ret void
|
|
}
|
|
|
|
define void @f2(i32 %x) nounwind uwtable {
|
|
; X86-LABEL: f2:
|
|
; X86: # BB#0: # %entry
|
|
; X86-NEXT: xabort $1
|
|
; X86-NEXT: calll f1
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: f2:
|
|
; X64: # BB#0: # %entry
|
|
; X64-NEXT: pushq %rax
|
|
; X64-NEXT: .cfi_def_cfa_offset 16
|
|
; X64-NEXT: movl %edi, {{[0-9]+}}(%rsp)
|
|
; X64-NEXT: xabort $1
|
|
; X64-NEXT: callq f1
|
|
; X64-NEXT: popq %rax
|
|
; X64-NEXT: retq
|
|
entry:
|
|
%x.addr = alloca i32, align 4
|
|
store i32 %x, i32* %x.addr, align 4
|
|
call void @llvm.x86.xabort(i8 1)
|
|
call void @f1()
|
|
ret void
|
|
}
|
|
|