mirror of
https://github.com/RPCS3/llvm.git
synced 2026-01-31 01:25:19 +01:00
Summary: There are several places in the codebase that try to calculate a maximum value in a Statistic object. We currently do this in one of two ways: MaxNumFoo = std::max(MaxNumFoo, NumFoo); or MaxNumFoo = (MaxNumFoo > NumFoo) ? MaxNumFoo : NumFoo; The first version reads from MaxNumFoo one time and uncontionally rwrites to it. The second version possibly reads it twice depending on the result of the first compare. But we have no way of knowing if the value was changed by another thread between the reads and the writes. This patch adds a method to the Statistic object that can ensure that we only store if our value is the max and the previous max didn't change after we read it. If it changed we'll recheck if our value should still be the max or not and try again. This spawned from an audit I'm trying to do of all places we uses the implicit conversion to unsigned on the Statistics objects. See my previous thread on llvm-dev https://groups.google.com/forum/#!topic/llvm-dev/yfvxiorKrDQ Reviewers: dberlin, chandlerc, hfinkel, dblaikie Reviewed By: chandlerc Subscribers: llvm-commits, sanjoy Differential Revision: https://reviews.llvm.org/D33301 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@303318 91177308-0d34-0410-b5e6-96231b3b80d8
189 lines
5.1 KiB
C++
189 lines
5.1 KiB
C++
//===-- llvm/ADT/Statistic.h - Easy way to expose stats ---------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines the 'Statistic' class, which is designed to be an easy way
|
|
// to expose various metrics from passes. These statistics are printed at the
|
|
// end of a run (from llvm_shutdown), when the -stats command line option is
|
|
// passed on the command line.
|
|
//
|
|
// This is useful for reporting information like the number of instructions
|
|
// simplified, optimized or removed by various transformations, like this:
|
|
//
|
|
// static Statistic NumInstsKilled("gcse", "Number of instructions killed");
|
|
//
|
|
// Later, in the code: ++NumInstsKilled;
|
|
//
|
|
// NOTE: Statistics *must* be declared as global variables.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_ADT_STATISTIC_H
|
|
#define LLVM_ADT_STATISTIC_H
|
|
|
|
#include "llvm/Support/Atomic.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
#include <atomic>
|
|
#include <memory>
|
|
|
|
namespace llvm {
|
|
|
|
class raw_ostream;
|
|
class raw_fd_ostream;
|
|
|
|
class Statistic {
|
|
public:
|
|
const char *DebugType;
|
|
const char *Name;
|
|
const char *Desc;
|
|
std::atomic<unsigned> Value;
|
|
bool Initialized;
|
|
|
|
unsigned getValue() const { return Value.load(std::memory_order_relaxed); }
|
|
const char *getDebugType() const { return DebugType; }
|
|
const char *getName() const { return Name; }
|
|
const char *getDesc() const { return Desc; }
|
|
|
|
/// construct - This should only be called for non-global statistics.
|
|
void construct(const char *debugtype, const char *name, const char *desc) {
|
|
DebugType = debugtype;
|
|
Name = name;
|
|
Desc = desc;
|
|
Value = 0;
|
|
Initialized = false;
|
|
}
|
|
|
|
// Allow use of this class as the value itself.
|
|
operator unsigned() const { return getValue(); }
|
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_STATS)
|
|
const Statistic &operator=(unsigned Val) {
|
|
Value.store(Val, std::memory_order_relaxed);
|
|
return init();
|
|
}
|
|
|
|
const Statistic &operator++() {
|
|
Value.fetch_add(1, std::memory_order_relaxed);
|
|
return init();
|
|
}
|
|
|
|
unsigned operator++(int) {
|
|
init();
|
|
return Value.fetch_add(1, std::memory_order_relaxed);
|
|
}
|
|
|
|
const Statistic &operator--() {
|
|
Value.fetch_sub(1, std::memory_order_relaxed);
|
|
return init();
|
|
}
|
|
|
|
unsigned operator--(int) {
|
|
init();
|
|
return Value.fetch_sub(1, std::memory_order_relaxed);
|
|
}
|
|
|
|
const Statistic &operator+=(unsigned V) {
|
|
if (V == 0)
|
|
return *this;
|
|
Value.fetch_add(V, std::memory_order_relaxed);
|
|
return init();
|
|
}
|
|
|
|
const Statistic &operator-=(unsigned V) {
|
|
if (V == 0)
|
|
return *this;
|
|
Value.fetch_sub(V, std::memory_order_relaxed);
|
|
return init();
|
|
}
|
|
|
|
void updateMax(unsigned V) {
|
|
unsigned PrevMax = Value.load(std::memory_order_relaxed);
|
|
// Keep trying to update max until we succeed or another thread produces
|
|
// a bigger max than us.
|
|
while (V > PrevMax && !Value.compare_exchange_weak(
|
|
PrevMax, V, std::memory_order_relaxed)) {
|
|
}
|
|
init();
|
|
}
|
|
|
|
#else // Statistics are disabled in release builds.
|
|
|
|
const Statistic &operator=(unsigned Val) {
|
|
return *this;
|
|
}
|
|
|
|
const Statistic &operator++() {
|
|
return *this;
|
|
}
|
|
|
|
unsigned operator++(int) {
|
|
return 0;
|
|
}
|
|
|
|
const Statistic &operator--() {
|
|
return *this;
|
|
}
|
|
|
|
unsigned operator--(int) {
|
|
return 0;
|
|
}
|
|
|
|
const Statistic &operator+=(const unsigned &V) {
|
|
return *this;
|
|
}
|
|
|
|
const Statistic &operator-=(const unsigned &V) {
|
|
return *this;
|
|
}
|
|
|
|
void updateMax(unsigned V) {}
|
|
|
|
#endif // !defined(NDEBUG) || defined(LLVM_ENABLE_STATS)
|
|
|
|
protected:
|
|
Statistic &init() {
|
|
bool tmp = Initialized;
|
|
sys::MemoryFence();
|
|
if (!tmp) RegisterStatistic();
|
|
TsanHappensAfter(this);
|
|
return *this;
|
|
}
|
|
|
|
void RegisterStatistic();
|
|
};
|
|
|
|
// STATISTIC - A macro to make definition of statistics really simple. This
|
|
// automatically passes the DEBUG_TYPE of the file into the statistic.
|
|
#define STATISTIC(VARNAME, DESC) \
|
|
static llvm::Statistic VARNAME = {DEBUG_TYPE, #VARNAME, DESC, {0}, false}
|
|
|
|
/// \brief Enable the collection and printing of statistics.
|
|
void EnableStatistics(bool PrintOnExit = true);
|
|
|
|
/// \brief Check if statistics are enabled.
|
|
bool AreStatisticsEnabled();
|
|
|
|
/// \brief Return a file stream to print our output on.
|
|
std::unique_ptr<raw_fd_ostream> CreateInfoOutputFile();
|
|
|
|
/// \brief Print statistics to the file returned by CreateInfoOutputFile().
|
|
void PrintStatistics();
|
|
|
|
/// \brief Print statistics to the given output stream.
|
|
void PrintStatistics(raw_ostream &OS);
|
|
|
|
/// Print statistics in JSON format. This does include all global timers (\see
|
|
/// Timer, TimerGroup). Note that the timers are cleared after printing and will
|
|
/// not be printed in human readable form or in a second call of
|
|
/// PrintStatisticsJSON().
|
|
void PrintStatisticsJSON(raw_ostream &OS);
|
|
|
|
} // end namespace llvm
|
|
|
|
#endif // LLVM_ADT_STATISTIC_H
|